aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authordylan.araps@gmail.com <dylan.araps@gmail.com>2020-01-28 19:21:20 +0000
committerdylan.araps@gmail.com <dylan.araps@gmail.com>2020-01-28 19:21:20 +0000
commit5323ceb1d111d3ab8527f2a398a8b26c4e66689c (patch)
tree14ea3f99cab9154548a452ebf6b24a3f03dfd8d0
parent5eec42b5f03658558c8e581c55402397bafc96eb (diff)
downloadcpt-5323ceb1d111d3ab8527f2a398a8b26c4e66689c.tar.gz
kiss: Avoid 'sed -i'
FossilOrigin-Name: 92e5faa77d8c440848d4d7b2479e762fdc778afb4f95cacab1870b2dfa53f883
-rwxr-xr-xkiss31
1 files changed, 20 insertions, 11 deletions
diff --git a/kiss b/kiss
index 24098e0..53ce64d 100755
--- a/kiss
+++ b/kiss
@@ -148,12 +148,24 @@ dosu() {
fi
}
-regex_escape() {
+ssed() {
+ # Simple wrapper around 'sed' to handle in-place
+ # replacements in a portable way.
+
# Escape all required characters in both the search and
# replace portions of two strings for use in a 'sed' call
# as "plain-text".
sea=$(echo "$1" | sed 's/[]\/$*.^[]/\\&/g')
rep=$(echo "$2" | sed 's/[\/&]/\\&/g')
+
+ # Save the replacement result to a temporary file and then
+ # overwrite the original file with it.
+ #
+ # The '$4' equates to a 'sudo'/'su' equivalent when parts
+ # of the function's body must run as 'root'. Globbing is
+ # disabled and the input hardcoded so this is fine.
+ $4 sed "s/$sea/$rep" "$3" > "$3.bak"
+ $4 mv -f "$3.bak" "$3"
}
pkg_lint() {
@@ -825,12 +837,10 @@ pkg_conflicts() {
mv -f "$tar_dir/$p_name/$con" \
"$tar_dir/$p_name/$cho_dir/$p_name$con_name"
- regex_escape "$con" "/$cho_dir/$p_name$con_name"
-
# Rewrite the package's manifest to update its location
# to its new spot (and name) in the choices directory.
- sed -i "s/$sea/$rep/" \
- "$tar_dir/$p_name/$pkg_db/$p_name/manifest"
+ ssed "$con" "/$cho_dir/$p_name$con_name" \
+ "$tar_dir/$p_name/$pkg_db/$p_name/manifest"
done
else
if "$grep" -Fxf "$cac_dir/$pid-m" -- "$@"; then
@@ -871,20 +881,19 @@ pkg_swap() {
log "Swapping '$2' from '$pkg_owns' to '$1'"
- regex_escape "$2" "$PWD/$pkg_owns>${alt#*>}"
# Convert the current owner to an alternative and rewrite
# its manifest file to reflect this.
- dosu cp -f "'$2'" "'$pkg_owns>${alt#*>}'"
- dosu sed -i "'s/$sea/$rep/'" "'../installed/$pkg_owns/manifest'"
+ dosu cp -f "'$2'" "'$pkg_owns>${alt#*>}'"
+ ssed "'$2'" "'$PWD/$pkg_owns>${alt#*>}'" \
+ "'../installed/$pkg_owns/manifest'" dosu
fi
- regex_escape "$PWD/$alt" "$2"
# Convert the desired alternative to a real file and rewrite
# the manifest file to reflect this. The reverse of above.
- dosu mv -f "'$alt'" "'$2'"
- dosu sed -i "'s/$sea/$rep/'" "'../installed/$1/manifest'"
+ dosu mv -f "'$alt'" "'$2'"
+ ssed "'$PWD/$alt'" "'$2'" "'../installed/$1/manifest'" dosu
}
pkg_remove() {