ash: expand: Do not quote backslashes in unquoted parameter expansion

2018-08-07T16:58:02+00:00

Upstream commit: Date: Wed, 28 Mar 2018 18:37:51 +0800 expand: Do not quote backslashes in unquoted parameter expansion Here is a better example: a="/*/\nullx" b="/*/\null"; printf "%s\n" $a $b dash currently prints /*/\nullx /*/\null bash prints /*/\nullx /dev/null You may argue the bash behaviour is inconsistent but it actually makes sense. What happens is that quote removal only applies to the original token as seen by the shell. It is never applied to the result of parameter expansion. Now you may ask why on earth does the second line say "/dev/null" instead of "/dev/\null". Well that's because it is not the quote removal step that removed the backslash, but the pathname expansion. The fact that the /de\v does not become /dev even though it exists is just the result of the optimisation to avoid unnecessarily calling stat(2). I have checked POSIX and I don't see anything that forbids this behaviour. So going back to dash yes I think we should adopt the bash behaviour for pathname expansion and keep the existing case semantics. This patch does exactly that. Note that this patch does not work unless you have already applied https://patchwork.kernel.org/patch/10306507/ because otherwise the optimisation mentioned above does not get detected correctly and we will end up doing quote removal twice. This patch also updates expmeta to handle naked backslashes at the end of the pattern which is now possible. Signed-off-by: Herbert Xu function old new delta expmeta 618 653 +35 memtodest 146 147 +1 Tested to work with both ASH_INTERNAL_GLOB on and off. hush does not handle this correctly. Signed-off-by: Denys Vlasenko

hush: never glob result of dquoted "${v:+/bin/c*}"

2018-07-20T17:29:41+00:00

Signed-off-by: Denys Vlasenko

hush testsuite: add glob_dir.tests

2016-10-02T13:20:57+00:00

Signed-off-by: Denys Vlasenko

ash,hush: add a test which fails for ash since commit 549deab

2015-09-04T01:33:02+00:00

Signed-off-by: Denys Vlasenko

hush: add brace expansion testcase

2010-10-03T15:07:57+00:00

Signed-off-by: Denys Vlasenko

hush: fix globbing+backslashes in unquoted $var expansion

2010-09-06T08:26:37+00:00

Signed-off-by: Denys Vlasenko

hush: add testsuite for "no globbing in redirection" rule.

2008-06-18T16:29:32+00:00

simplify redirection habdling

move glob_and_assign.tests from hush-bugs to hush-glob

2008-06-17T07:26:52+00:00

hush: fix escaping of \[*?; add testsuites for these and for globbing

2008-06-10T20:13:40+00:00

forks/busybox/shell/hush_test/hush-glob, branch master

ash: expand: Do not quote backslashes in unquoted parameter expansion

hush: never glob result of dquoted "${v:+/bin/c*}"

hush testsuite: add glob_dir.tests

ash,hush: add a test which fails for ash since commit 549deab

hush: add brace expansion testcase

hush: fix globbing+backslashes in unquoted $var expansion

hush: add testsuite for "no globbing in redirection" rule.

move glob_and_assign.tests from hush-bugs to hush-glob

hush: fix escaping of \[*?; add testsuites for these and for globbing