aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorJohn Beppu <beppu@lbox.org>2000-06-27 04:56:45 +0000
committerJohn Beppu <beppu@lbox.org>2000-06-27 04:56:45 +0000
commit27b5924b96fc71a6f70ea1a13a5232fca2439e7d (patch)
tree48b399259f741dc28e34da5955a72292031e946b
parent8f425dbf9a8af9d3ee9848a18a641a93d9fe039b (diff)
downloadbusybox-27b5924b96fc71a6f70ea1a13a5232fca2439e7d.tar.gz
+ littering my code w/ comments about what troubles me.
-rw-r--r--applets/busybox.c7
-rw-r--r--busybox.c7
2 files changed, 12 insertions, 2 deletions
diff --git a/applets/busybox.c b/applets/busybox.c
index 78f07e338..5f1c56bc3 100644
--- a/applets/busybox.c
+++ b/applets/busybox.c
@@ -420,10 +420,15 @@ int main(int argc, char **argv)
const struct BB_applet *a = applets;
#ifdef BB_FEATURE_INSTALLER
+ /*
+ * This style of argument parsing doesn't scale well
+ * in the event that busybox starts wanting more --options.
+ * If someone has a cleaner approach, by all means implement it.
+ */
if (argc > 1 && (strcmp(argv[1], "--install") == 0)) {
int use_symbolic_links = 0;
- /* to use symlinks, or to not use symlinks... */
+ /* to use symlinks, or not to use symlinks... */
if (argc > 2) {
if ((strcmp(argv[2], "-s") == 0)) {
use_symbolic_links = 1;
diff --git a/busybox.c b/busybox.c
index 78f07e338..5f1c56bc3 100644
--- a/busybox.c
+++ b/busybox.c
@@ -420,10 +420,15 @@ int main(int argc, char **argv)
const struct BB_applet *a = applets;
#ifdef BB_FEATURE_INSTALLER
+ /*
+ * This style of argument parsing doesn't scale well
+ * in the event that busybox starts wanting more --options.
+ * If someone has a cleaner approach, by all means implement it.
+ */
if (argc > 1 && (strcmp(argv[1], "--install") == 0)) {
int use_symbolic_links = 0;
- /* to use symlinks, or to not use symlinks... */
+ /* to use symlinks, or not to use symlinks... */
if (argc > 2) {
if ((strcmp(argv[2], "-s") == 0)) {
use_symbolic_links = 1;