aboutsummaryrefslogtreecommitdiff
diff options
context:
space:
mode:
authorDenys Vlasenko <vda.linux@googlemail.com>2016-10-24 21:12:33 +0200
committerDenys Vlasenko <vda.linux@googlemail.com>2016-10-24 21:12:33 +0200
commitdb74c6caedf752623820cd09f7fbeaf4152e1de8 (patch)
treec571da864f785eb3025201989a45375267591e19
parent61d5997b586a28f79d54b28ce6963b643dff6e9e (diff)
downloadbusybox-db74c6caedf752623820cd09f7fbeaf4152e1de8.tar.gz
ash: explain EXP_REDIR and why we (dont) glob redir filenames
Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
-rw-r--r--shell/ash.c11
1 files changed, 11 insertions, 0 deletions
diff --git a/shell/ash.c b/shell/ash.c
index c9d39b875..d9595bb8f 100644
--- a/shell/ash.c
+++ b/shell/ash.c
@@ -5545,6 +5545,17 @@ ash_arith(const char *s)
#define EXP_TILDE 0x2 /* do normal tilde expansion */
#define EXP_VARTILDE 0x4 /* expand tildes in an assignment */
#define EXP_REDIR 0x8 /* file glob for a redirection (1 match only) */
+/* ^^^^^^^^^^^^^^ this is meant to support constructs such as "cmd >file*.txt"
+ * POSIX says for this case:
+ * Pathname expansion shall not be performed on the word by a
+ * non-interactive shell; an interactive shell may perform it, but shall
+ * do so only when the expansion would result in one word.
+ * Currently, our code complies to the above rule by never globbing
+ * redirection filenames.
+ * Bash performs globbing, unless it is non-interactive and in POSIX mode.
+ * (this means that on a typical Linux distro, bash almost always
+ * performs globbing, and thus diverges from what we do).
+ */
#define EXP_CASE 0x10 /* keeps quotes around for CASE pattern */
#define EXP_QPAT 0x20 /* pattern in quoted parameter expansion */
#define EXP_VARTILDE2 0x40 /* expand tildes after colons only */