diff options
| author | Eric Andersen <andersen@codepoet.org> | 2001-01-30 18:03:11 +0000 |
|---|---|---|
| committer | Eric Andersen <andersen@codepoet.org> | 2001-01-30 18:03:11 +0000 |
| commit | e57d54b456bf091aded43fc95bee9b05e7461dd0 (patch) | |
| tree | ab02892c3929a64304d457f6857a68e01efea145 /coreutils/ls.c | |
| parent | 201dc0d5a99b8ef765f2b79e6a492a70772a0774 (diff) | |
| download | busybox-e57d54b456bf091aded43fc95bee9b05e7461dd0.tar.gz | |
Fix ls behavior for broken or very narrow terminals. Fix my_*
functions so they comply with the original interface (i.e. don't
exit on error, stringify uids and gids when no amtching name found).
-Erik
Diffstat (limited to 'coreutils/ls.c')
| -rw-r--r-- | coreutils/ls.c | 42 |
1 files changed, 25 insertions, 17 deletions
diff --git a/coreutils/ls.c b/coreutils/ls.c index affa48c12..2ed5fe165 100644 --- a/coreutils/ls.c +++ b/coreutils/ls.c @@ -41,9 +41,12 @@ * 1. requires lstat (BSD) - how do you do it without? */ -static const int TERMINAL_WIDTH = 80; /* use 79 if your terminal has linefold bug */ -static const int COLUMN_WIDTH = 14; /* default if AUTOWIDTH not defined */ -static const int COLUMN_GAP = 2; /* includes the file type char, if present */ +enum { + TERMINAL_WIDTH = 80, /* use 79 if terminal has linefold bug */ + COLUMN_WIDTH = 14, /* default if AUTOWIDTH not defined */ + COLUMN_GAP = 2, /* includes the file type char */ +}; + /************************************************************************/ @@ -173,9 +176,9 @@ static unsigned int follow_links=FALSE; static unsigned short column = 0; #ifdef BB_FEATURE_AUTOWIDTH -static unsigned short terminal_width; -static unsigned short column_width; -static unsigned short tabstops; +static unsigned short terminal_width = TERMINAL_WIDTH; +static unsigned short column_width = COLUMN_WIDTH; +static unsigned short tabstops = COLUMN_GAP; #else static unsigned short column_width = COLUMN_WIDTH; #endif @@ -434,9 +437,15 @@ void showfiles(struct dnode **dn, int nfiles) ((list_fmt & LIST_INO) ? 8 : 0) + ((list_fmt & LIST_BLOCKS) ? 5 : 0) ; - if (column_width < len) column_width= len; + if (column_width < len) + column_width= len; + } + if (column_width >= 6) + ncols = (int)(terminal_width / (column_width + COLUMN_GAP)); + else { + ncols = 1; + column_width = COLUMN_WIDTH; } - ncols= (int)(terminal_width / (column_width + COLUMN_GAP)); #else ncols= TERMINAL_WIDTH; #endif @@ -447,7 +456,12 @@ void showfiles(struct dnode **dn, int nfiles) break; } - nrows= nfiles / ncols; + if (ncols > 1) { + nrows = nfiles / ncols; + } else { + nrows = nfiles; + ncols = 1; + } if ((nrows * ncols) < nfiles) nrows++; /* round up fractionals */ if (nrows > nfiles) nrows= nfiles; @@ -617,15 +631,9 @@ int list_single(struct dnode *dn) case LIST_ID_NAME: #ifdef BB_FEATURE_LS_USERNAME my_getpwuid(scratch, dn->dstat.st_uid); - if (*scratch) - printf("%-8.8s ", scratch); - else - printf("%-8d ", dn->dstat.st_uid); + printf("%-8.8s ", scratch); my_getgrgid(scratch, dn->dstat.st_gid); - if (*scratch) - printf("%-8.8s", scratch); - else - printf("%-8d", dn->dstat.st_gid); + printf("%-8.8s", scratch); column += 17; break; #endif |