diff options
| author | Denis Vlasenko <vda.linux@googlemail.com> | 2007-07-27 11:20:10 +0000 |
|---|---|---|
| committer | Denis Vlasenko <vda.linux@googlemail.com> | 2007-07-27 11:20:10 +0000 |
| commit | 3734b946bfef55c8f63d367422da5c7aa7b972db (patch) | |
| tree | 1bdd3e14523002dc8276d167b17f900e40fa6dff /libbb/procps.c | |
| parent | 661f6fad77b672a5f6648b01275eb9ff19c59139 (diff) | |
| download | busybox-3734b946bfef55c8f63d367422da5c7aa7b972db.tar.gz | |
bb_getpwuid, bb_getgrgid: change order of arguments to more intuitive one;
comment thoroughly when they die and when they dont.
Diffstat (limited to 'libbb/procps.c')
| -rw-r--r-- | libbb/procps.c | 5 |
1 files changed, 3 insertions, 2 deletions
diff --git a/libbb/procps.c b/libbb/procps.c index 37593700a..aa207af6f 100644 --- a/libbb/procps.c +++ b/libbb/procps.c @@ -52,7 +52,7 @@ static int get_cached(cache_t *cp, unsigned id) } #endif -typedef char* ug_func(char *name, long uid, int bufsize); +typedef char* ug_func(char *name, int bufsize, long uid); static char* get_cached(cache_t *cp, unsigned id, ug_func* fp) { int i; @@ -62,7 +62,8 @@ static char* get_cached(cache_t *cp, unsigned id, ug_func* fp) i = cp->size++; cp->cache = xrealloc(cp->cache, cp->size * sizeof(*cp->cache)); cp->cache[i].id = id; - fp(cp->cache[i].name, id, sizeof(cp->cache[i].name)); + /* Never fails. Generates numeric string if name isn't found */ + fp(cp->cache[i].name, sizeof(cp->cache[i].name), id); return cp->cache[i].name; } const char* get_cached_username(uid_t uid) |