diff options
author | Eric Andersen <andersen@codepoet.org> | 2004-03-16 05:14:10 +0000 |
---|---|---|
committer | Eric Andersen <andersen@codepoet.org> | 2004-03-16 05:14:10 +0000 |
commit | 16767e2377210fb7489ee4d7d79ad1850c7c932d (patch) | |
tree | 60d41b5ef57193173d1eecd747a0ddb3130e90ea /loginutils/deluser.c | |
parent | ca65ca7d450ae6cbc0702e6b10925ccaef982bb4 (diff) | |
download | busybox-16767e2377210fb7489ee4d7d79ad1850c7c932d.tar.gz |
Patch from vodz to fix the dynamic vars patch, which I should not
have checked in. Vladimir writes:
Your patch have many problem.
1. You always added + time(). This cannot reset RANDOM=value for debuging
with
replay sequential.
2. Hmm. I examine bash 2.04 source. This pseudorandom generator use low bits
of
counter value. You use high bits. This make bad pseudorandom values after
have
0-value. For example, if + time() do remove, your generator always return 0
after
first generate 0.
3. Memory leak per call. Use ash-unlike unecessary bb_strdup function.
4. Unsupport show last $RANDOM value for "set" and "export" command.
5. Bloat code. Busybox-unlike patch - added unstandart feature as default
hardcode.
Last patch attached.
Erik, why you apply Paul patch with have 5-th point problem? :(
Last patch have ash change xwrite() to fresh libbb/bb_full_write interfase
(haved loop after EINTR).
--w
vodz
Diffstat (limited to 'loginutils/deluser.c')
0 files changed, 0 insertions, 0 deletions