diff options
author | Eric Andersen <andersen@codepoet.org> | 2004-10-08 07:21:58 +0000 |
---|---|---|
committer | Eric Andersen <andersen@codepoet.org> | 2004-10-08 07:21:58 +0000 |
commit | 2842659cc02233274ca165ffb83a31b161d815cd (patch) | |
tree | 7f9d0ea0e20dcc8bc53fcc0035a3e955820c5ded /sysklogd/Config.in | |
parent | d952ee2e9ed15fc19c58938ab6005e95e6a595dc (diff) | |
download | busybox-2842659cc02233274ca165ffb83a31b161d815cd.tar.gz |
Patch from Michael Tokarev:
Scenario:
touch x -- creates plain file name `x'
mkdir x -- exits successefully
libbb/make_directory.c, bb_make_directory(), contains
the following code:
if (mkdir(path, 0777) < 0) {
/* If we failed for any other reason than the directory
* already exists, output a diagnostic and return -1.*/
if (errno != EEXIST) {
fail_msg = "create";
umask(mask);
break;
}
/* Since the directory exists, don't attempt to change
* permissions if it was the full target. Note that
* this is not an error conditon. */
if (!c) {
umask(mask);
return 0;
}
}
The assumption that EEXIST error is due to that the *directory*
already exists is wrong: any file type with that name will cause
this error to be returned. Proper way IMHO will be is to stat()
the path and check whenever this is really a directory. Below
(attached) is a patch to fix this issue.
Diffstat (limited to 'sysklogd/Config.in')
0 files changed, 0 insertions, 0 deletions