aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2004-10-08egor duda writes:Eric Andersen
Hi! I've created a patch to busybox' build system to allow building it in separate tree in a manner similar to kbuild from kernel version 2.6. That is, one runs command like 'make O=/build/some/where/for/specific/target/and/options' and everything is built in this exact directory, provided that it exists. I understand that applyingc such invasive changes during 'release candidates' stage of development is at best unwise. So, i'm currently asking for comments about this patch, starting from whether such thing is needed at all to whether it coded properly. 'make check' should work now, and one make creates Makefile in build directory, so one can run 'make' in build directory after that. One possible caveat is that if we build in some directory other than source one, the source directory should be 'distclean'ed first. egor
2004-10-08Patch from Michael Tokarev:Eric Andersen
Scenario: touch x -- creates plain file name `x' mkdir x -- exits successefully libbb/make_directory.c, bb_make_directory(), contains the following code: if (mkdir(path, 0777) < 0) { /* If we failed for any other reason than the directory * already exists, output a diagnostic and return -1.*/ if (errno != EEXIST) { fail_msg = "create"; umask(mask); break; } /* Since the directory exists, don't attempt to change * permissions if it was the full target. Note that * this is not an error conditon. */ if (!c) { umask(mask); return 0; } } The assumption that EEXIST error is due to that the *directory* already exists is wrong: any file type with that name will cause this error to be returned. Proper way IMHO will be is to stat() the path and check whenever this is really a directory. Below (attached) is a patch to fix this issue.
2004-10-07Make it more apparent that archive creation is not supportedEric Andersen
2004-09-30Patch from William Barsse to fix a segfault when multiple files are specified.Glenn L McGrath
2004-09-24Patch from Dmitry Zakharov to fix a bug triggered by freeswan's scripts.Glenn L McGrath
2004-09-24Patch from Egor DudaGlenn L McGrath
Attached patch prevents modprobe from trying to call 'insmod (null)' whenever nonexistent module is either passed to modprobe via command line or mentioned in modules.dep this replaces cryptic error sh: Syntax error: word unexpected (expecting ")") with modprobe: module some-module not found. egor.
2004-09-24Fix a typoGlenn L McGrath
2004-09-24Remove this error message at Vodz request, it was misleading.Glenn L McGrath
2004-09-24Patch from David Daney to make the -i option work with -l.Glenn L McGrath
2004-09-24A bit of extra explanation regarding STANDALONEEric Andersen
2004-09-23Add some notes on how to make telnetd actually workEric Andersen
2004-09-15Add a missing brace, patch by Hideki IWAMOTOGlenn L McGrath
2004-09-15Tito writes,Glenn L McGrath
"This patch fixes all the bugs in id previously spotted by vodz and me. The binary size increased a bit, but now it should work as expected."
2004-09-15Only write to shadow file is shadow passwords are enabled. Patch by magicfox ↵Glenn L McGrath
modified by myself to retain check for shadow file access.
2004-09-15Patch by Felipe Kellermann, use the common escape handling function and ↵Glenn L McGrath
remove some unused code.
2004-09-14remove a cut/paste mistake, i better get some sleep.Glenn L McGrath
2004-09-14Apply patch from Felipe Kellermann to simlify logic of sort functions.Glenn L McGrath
I reversed the result of the sort functions to make the big numbers go to the top.
2004-09-14Patch by Felipe Kellermann, fix a bug introduced in the last patch by adding ↵Glenn L McGrath
a condition around the remote logging, also adds some comments.
2004-09-14Patch from Felipe Kellermann, remove some unnecessary dups, i declared a few ↵Glenn L McGrath
extra const's also.
2004-09-14Patch from Felipe Kellermann, adds missing applet usage options, removes usageGlenn L McGrath
for options that are currently not implemented and fixes typos.
2004-09-14Patch from tito to add argument checking.Glenn L McGrath
2004-09-14I have to assume both Avaks and LSILogic are deliberatly ignoring me.Glenn L McGrath
2004-09-08Fixup URLEric Andersen
2004-09-08Felipe Kellermann writes:Eric Andersen
The Togg's sysklogd patch to use sendto() on remote logging is formatting strangely (using `<' and '>' surrounding the `msg' string message). This is OK, but this is not the standard way of formatting this message. So this patch does the following: o Fix the formatting to the standard way. o Uses `MAXLINE' when needed; o Don't loop sending messages without a "sleeping time", I'm now doing `now = 1', `now <<= 1'; o Don't die on `init_RemoteLog' when starting up (feature!) We're now trying to connect every time we have an invalid fd; o Removes one static uneeded variable. o Removes two automatic uneeded variables.
2004-09-08Patrick Huesmann noticed BusyBox would not link whenEric Andersen
CONFIG_FEATURE_COMMAND_EDITING was defined *and* CONFIG_FEATURE_COMMAND_TAB_COMPLETION was undefined. Vladimir N. Oleynik writes: Its declare always, also if CONFIG_FEATURE_COMMAND_TAB_COMPLETION undefined. Patch to CVS version attached. --w vodz
2004-09-02Jonas Holmberg from axis dot com writes:Eric Andersen
This patch makes msh handle variable expansion within backticks more correctly. Current behaviour (wrong): -------------------------- BusyBox v1.00-rc3 (2004.08.26-11:51+0000) Built-in shell (msh) Enter 'help' for a list of built-in commands. $ A='`echo hello`' $ echo $A `echo hello` $ echo `echo $A` hello $ New behaviour (correct): ------------------------ BusyBox v1.00-rc3 (2004.08.26-11:51+0000) Built-in shell (msh) Enter 'help' for a list of built-in commands. $ A='`echo hello`' $ echo $A `echo hello` $ echo `echo $A` `echo hello` $ The current behaviour (wrong according to standards) was actually my fault. msh handles backticks by executing a subshell (which makes it work on MMU-less systems). Executing a subshell makes it hard to only expand variables once in the parent. Therefore I export all variables that will be expanded within the backticks and let the subshell handle the expansion instead. The bug was found while searching for security leaks in CGI-scripts. Current behaviour of msh makes it easy to expand backticks by mistake in $QUERY_STRING. I recommend appling the patch before release of bb 1.00. /Jonas
2004-09-02No longer neededEric Andersen
2004-09-02Based on patches from Mike Frysinger, add insmod support forEric Andersen
sparc and ia64 (itanium). Also, reorganize the insmod architecture support code to be alphasorted and less messy. Update the readme to list current insmod arch support.
2004-09-02Tito writes:Eric Andersen
The second patch contains: 1) a size optimization for adduser.c 2) removes a warning about an unused variable in syslogd.c if CONFIG_FEATURE_REMOTE_LOG is not set 3)cosmetic fixes for addgroup_full_usage and adduser_full_usage Ciao, Tito
2004-09-02Tito writes:Eric Andersen
Hi Erik, Hi to all, This is part five of the my_get*id story. I've tweaked a bit this two functions to make them more flexible, but this changes will not affect existing code. Now they work so: 1) my_getpwuid( char *user, uid_t uid, int bufsize) if bufsize is > 0 char *user cannot be set to NULL on success username is written on static allocated buffer on failure uid as string is written to buffer and NULL is returned if bufsize is = 0 char *user can be set to NULL on success username is returned on failure NULL is returned if bufsize is < 0 char *user can be set to NULL on success username is returned on failure an error message is printed and the program exits 2) 1) my_getgrgid( char *group, uid_t uid, int bufsize) if bufsize is > 0 char *group cannot be set to NULL on success groupname is written on static allocated buffer on failure gid as string is written to buffer and NULL is returned if bufsize is = 0 char *group can be set to NULL on success groupname is returned on failure NULL is returned if bufsize is < 0 char *group can be set to nULL on success groupname is returned on failure an error message is printed and the program exits This changes were needed mainly for my new id applet. It is somewhat bigger then the previous but matches the behaviour of GNU id and is capable to handle usernames of whatever length. BTW: at a first look it seems to me that it will integrate well (with just a few changes) with the pending patch in patches/id_groups_alias.patch. The increase in size is balanced by the removal of my_getpwnamegid.c from libbb as this was used only in previous id applet and by size optimizations made possible in whoami.c and in passwd.c. I know that we are in feature freeze but I think that i've tested it enough (at least I hope so.......).
2004-08-28Fixup some warningsEric Andersen
2004-08-27Quiet a few warningsEric Andersen
2004-08-26Togg writes:Eric Andersen
Syslogd wont start if remote-logging is enabled and the connection to the remote-log server is not possible on syslogd startup. I found a patch somewhere which works like a charm. It uses sendto() which seems more reliable for this issue. Please see attached patch. Many people will be more happy with this included I think. Regards, Togg
2004-08-26Improve the setuid situation a bit, and make it more apparentEric Andersen
when people really ought to make busybox setuid root. -Erik
2004-08-26The login applet should always be setuid rootEric Andersen
2004-08-26Tito writes:Eric Andersen
Hi, I've fixed also the issue of whoami cutting down usernames. This time I cannot send a diff because i don't know if my previous patches will be applied or not, so I send in the whole file. The changes I've made don't affect size but ensure that usernames of whatever lenght are correctly displayed. root@localhost:/dev/pts/3:/root/Desktop/busybox/coreutils# size whoami_orig.o text data bss dec hex filename 102 0 0 102 66 whoami_orig.o root@localhost:/dev/pts/3:/root/Desktop/busybox/coreutils# size whoami.o text data bss dec hex filename 93 0 0 93 5d whoami.o This should be applied even if the other patches aren't as this matches the behaviour of the GNU whoami. Thanks in advance, Ciao, Tito
2004-08-26Save a line or twoEric Andersen
2004-08-26Vladimir N. Oleynik writes:Eric Andersen
Ming-Ching, >>No. Here there are no mistakes. >>You using POST metod. >>For get data you should read from stdin CONTENT_LENGTH bytes. >Hower as I posted a little while ago, there is indeed a bug >in POST method if the CONTENT_LENGTH is bigger >than sizeof(wbuf[128]). So if your CGI script is expecting to >read the full CONTENT_LENGTH, it might block forever, >because it will only transfer sizeof(wbuf) to the CGI. Ok, Ok. I should find time to understand with a problem. Try attached patch. --w vodz
2004-08-26Tito writes:Eric Andersen
Hi, I've spent the half night staring at the devilish my_getpwuid and my_getgrgid functions trying to find out a way to avoid actual and future potential buffer overflow problems without breaking existing code. Finally I've found a not intrusive way to do this that surely doesn't break existing code and fixes a couple of problems too. The attached patch: 1) changes the behaviour of my_getpwuid and my_getgrgid to avoid potetntial buffer overflows 2) fixes all occurences of this function calls in tar.c , id.c , ls.c, whoami.c, logger.c, libbb.h. 3) The behaviour of tar, ls and logger is unchanged. 4) The behavior of ps with somewhat longer usernames messing up output is fixed. 5) The only bigger change was the increasing of size of the buffers in id.c to avoid false negatives (unknown user: xxxxxx) with usernames longer than 8 chars. The value i used ( 32 chars ) was taken from the tar header ( see gname and uname). Maybe this buffers can be reduced a bit ( to 16 or whatever ), this is up to you. 6) The increase of size of the binary is not so dramatic: size busybox text data bss dec hex filename 239568 2300 36816 278684 4409c busybox size busybox_fixed text data bss dec hex filename 239616 2300 36816 278732 440cc busybox 7) The behaviour of whoami changed: actually it prints out an username cut down to the size of the buffer. This could be fixed by increasing the size of the buffer as in id.c or avoid the use of my_getpwuid and use getpwuid directly instead. Maybe this colud be also remain unchanged...... Please apply if you think it is ok to do so. The diff applies on today's cvs tarball (2004-08-25). Thanks in advance, Ciao, Tito
2004-08-26Felipe Kellermann writes:Eric Andersen
Unfortunatelly I've not followed the last two or three weeks commits (new semester started and so now I rarely have time to fix my personal bridge) but tonight I synched my tree and immediately noticed a rather nasty bug! [Using libbb/interface.c:1.24] # grep eth0 /proc/net/dev | xargs eth0:311708397 237346 1670 0 1789 1670 0 0 22580308 120297 0 0 0 102 0 0 # ifconfig eth0 eth0 Link encap:Ethernet HWaddr 00:20:AF:7C:EA:B7 inet addr:10.0.0.1 Bcast:10.0.0.127 Mask:255.255.255.128 UP BROADCAST RUNNING MULTICAST MTU:1500 Metric:1 RX packets:0 errors:0 dropped:0 overruns:0 frame:0 TX packets:0 errors:0 dropped:0 overruns:0 carrier:0 collisions:0 txqueuelen:1000 RX bytes:0 (0.0 B) TX bytes:0 (0.0 B) Interrupt:5 Base address:0x320 All values `ifconfig' is showing are `zeroed' -- I quickly looked at the last commits I missed and noticed that there were a commit relating to ifconfig, libbb/interface.c:1.23->1.24 (PatchSet 4338). I've reversed the patch and now everything is working again. I compared the get_name's return values from the 1.23 and 1.24 and quickly noticed that the new revision is leaving `p' right on the sep while the rev 1.23 was leaving it right on the starting of the values... 1-line, 1/3-minute patch attached :-)
2004-08-25Patch from Manousaridis Angelos to cleanup stale file descriptors, it was ↵Glenn L McGrath
preventing unmounting an initial filesystem.
2004-08-19Patch from Rodney Radford adding x86_64 support.Eric Andersen
2004-08-19regularly update the status line displayEric Andersen
-Erik
2004-08-19Patch from Mike Castle to cleanup some modutils issues, inEric Andersen
particular making alias support work better.
2004-08-19Patch from Tito adding support for '-q'Eric Andersen
2004-08-19Patch from Tito documenting the '-q' optionEric Andersen
2004-08-19Patch from Vladimir N. Oleynik:Eric Andersen
On Wed Aug 18, 2004 at 06:52:57PM +0800, Matt Johnston wrote: > I've come across some strange-seeming behaviour when running programs > under Busybox (1.0.0-rc3) ash. If the child process sets stdin to be > non-blocking and then exits, the parent ash will also exit. A quick strace > shows that a subsequent read() from stdin returns EAGAIN (as would be > expected): Thanks! Patch attached. --w vodz
2004-08-18Fixup 'dc' usageEric Andersen
2004-08-16Prepare for releaseEric Andersen
2004-08-16Bump versionEric Andersen