aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2005-06-11Note that memory allocaiton needs to be cleaned up too.Rob Landley
2005-06-11remove com_err.h includesMike Frysinger
2005-06-11DOS only crapMike Frysinger
2005-06-11import initial fat mke2fsMike Frysinger
2005-06-11import tune2fs supportMike Frysinger
2005-06-11fix signed/unsigned char pointersMike Frysinger
2005-06-11oops, we only want to affect local CFLAGSMike Frysinger
2005-06-11initial fat tune2fs/findfs/e2label sourceMike Frysinger
2005-06-11replace simple is_null func with a memcmp defineMike Frysinger
2005-06-11force including of e2fsbb.h and move the HAVE_* defines to itMike Frysinger
2005-06-11move config.h requirement to the actual .depend target rather than the ↵Mike Frysinger
depend alias
2005-06-11make sure clean removes objects in subdirsMike Frysinger
2005-06-11need strings.h for ffs()Mike Frysinger
2005-06-11only define some variables if legacy EXT2FS_ENABLE_SWAPFS is enabledMike Frysinger
2005-06-11replace simple functions with definesMike Frysinger
2005-06-11whitespace updatesMike Frysinger
2005-06-11replace functions with definesMike Frysinger
2005-06-11whitespace updatesMike Frysinger
2005-06-11whitespace updatesMike Frysinger
2005-06-11recode functions to shrink sizeMike Frysinger
2005-06-11setup the HAVE_* definesMike Frysinger
2005-06-09About time to just apply this and kill off the patchesEric Andersen
2005-06-07Tito posted a devfsd error message fix. It's highly deprecated and willRob Landley
presumably be removed eventually (use udev), but as long as it's in there. Tito says: The sense of this patch is to call: read_config_file_err: #ifdef CONFIG_DEVFSD_VERBOSE msg_logger(((optional == 0 ) && (errno == ENOENT))? DIE : NO_DIE, LOG_ERR, "read config file: %s: %m\n", path); #else if(optional == 0 && errno == ENOENT) exit(EXIT_FAILURE); #endif just after the failure of the call that set errno ( stat and fopen) to avoid false error messages.
2005-06-07Clean up strings.c to use busybox's option processing. Bug 006, apparently.Rob Landley
2005-06-07Patch from Dmitry Zakharov:Rob Landley
Charlie Brady wrote: > Here's another awk parsing problem - unary post increment - pre is fine: > >bash-2.05a$ echo 2,3 | gawk -F , '{ $2++ }' >bash-2.05a$ echo 2,3 | /tmp/busybox/busybox awk -F , '{ $2++ }' >awk: cmd. line:1: Unexpected token > Here's a fix for this. There is another problem with constructions like "print (A+B) ++C", I don't know whether somebody uses such constructions (fixing both these problems would require very serious change in awk code).
2005-06-07Thus spake Brenda J. Butler:Rob Landley
We were seeing some timeouts when getting files with the busybox tftp client. With tcpdump, we saw that the tftp client was receiving blocks and ack'ing them, but the server was failing to receive the occasional ack. When that happened, the server would send the last block over again, but the tftp client was expecting the next block. This patch allows the client to recover from this situation (it sends an ack for the repeat block but does not write it to the local file). I hope it meets your approval, please don't hesitate to send me comments for improvement. The patch is against "head" in svn, I tested it on an older version of busybox in our environment. It applied cleanly to the older version. Credit for this goes to my co-worker John McCarthy for finding it and me for fixing it (assuming it works for everyone else too). cheerio, bjb
2005-05-28Shaun Jackman submitted a patch converting an allocation to useRob Landley
CONFIG_RESERVE_BUFFER. (Rob Landley removed an #ifdef, per discussion on the list.)
2005-05-28Patch from Shaun Jackman to save a few bytes.Rob Landley
2005-05-26Tobias Krawutschke found a bug where the DHCP client would accept packetsRob Landley
with the wrong ARP address, meaning we could easily get somebody else's IP. That is a bad thing, and this is the minimal two-line fix.
2005-05-20Add readprofile applet support.Paul Mundt
2005-05-18Patch from Colin Watson (mangled slightly by Rob Landley):Rob Landley
This patch implements the 'T' command in sed. This is a GNU extension, but one of the udev hotplug scripts uses it, so I need it in busybox anyway. Includes a test; 'svn add testsuite/sed/sed-branch-conditional-inverted' after applying.
2005-05-18Doug Swarin pointed out a security bug in the -i option of sed.Rob Landley
While the permissions on the temp file are correct to prevent it from being maliciously mangled by passing strangers, (created with 600, opened O_EXCL, etc), the permissions on the _directory_ might not be, and we re-open the file to convert the filehandle to a FILE * (and automatically get an error message and exit if the directory's read-only or out of space or some such). This opens a potential race condition if somebody's using dnotify on the directory, deletes/renames the tempfile, and drops a symlink or something there. Somebody running sed -i as root in a world writeable directory could do damage. I dug up notes on an earlier discussion where we looked at the security implications of this (unfortunately on the #uclibc channel rather than email; I don't have a transcript, just notes-to-self) which pointed out that if the permissions on the directory allow other people's files to be deleted/renamed then the original file is vulnerable to sabotage anyway. However, there are two cases that discussion apparently didn't take into account: 1) Using another user's permissions to damage files in other directories you can't access (standard symlink attack). 2) Reading data another user couldn't otherwise access by having the new file belong to that other user. This patch uses fdopen to convert the filehandle into a FILE *, rather than reopening the file.
2005-05-16use more busybox functions and remove redundant codeMike Frysinger
2005-05-16make sure we add the local dir to the include pathMike Frysinger
2005-05-15Tito pointed out I'd broken -t (argv[optind] can't be before getulflags),Rob Landley
and replaced the use of system() (and resulting security implications).
2005-05-14Add automatic umount support to eject command. Patch from Tito,Rob Landley
with tweaks from Mike Frysinger and Rob Landley. Note: this will still fail to umount a path that contains an ' or \ character. Is it worth the extra size to filter for that?
2005-05-13as Rob Landley pointed out, need to fix the 1 versus i typo in indexingMike Frysinger
2005-05-13blah, forgot to save last time to fix whitespacingMike Frysinger
2005-05-13remove duplicated code and rework algorithms to end up with smaller codeMike Frysinger
2005-05-12use a bunch of if statements since it is a few bytes smaller than a switch; ↵Mike Frysinger
also use bb_xfopen() instead of fopen() so comm doesnt segfault when given non-existant files :(
2005-05-12err, added 2 to the wrong var :) also touchup the option detection to shrink ↵Mike Frysinger
size
2005-05-12fix segfault if user only specifies 1 fileMike Frysinger
2005-05-12update usage to match actual behaviorMike Frysinger
2005-05-12fix whitespace/coding styleMike Frysinger
2005-05-12add missing comm.o ruleMike Frysinger
2005-05-12whitespace touchupsMike Frysinger
2005-05-11This makefile was a mess. Fix it to work as intended.Eric Andersen
-Erik
2005-05-11Small comm implementatin from Rob Sullivan. Needed to build perl.Rob Landley
2005-05-11import ether-wake applet by haveaniceday Bug 252Mike Frysinger
2005-05-11change the hardcoded error constant (0x80000000UL) to a nice flexible define ↵Mike Frysinger
(BB_GETOPT_ERROR)