Age | Commit message (Collapse) | Author |
|
other warnings is just gross.)
On a side note, while I was there, I made the code slightly smaller.
|
|
|
|
|
|
|
|
s/fileno\(stdout\)/STDOUT_FILENO/g
|
|
|
|
|
|
new code returns 0 for success.
|
|
|
|
descriptors, support tar -j
|
|
|
|
on i386. also staticify most functions.
|
|
it does unless srcMode was set, and srcMode is never set.
|
|
still needs major attention (i.e. removal).
Removed references to uninitialized variables like progName,
smallMode, noisy, etc. Remove functions and code for handling "small"
decompression mode, since it is all unreachable. Remove
total_{in,out}* counters - they are never used. Remove panic()
function and assert_h and their uses because they are all for "should
never happen" circumstances. Replace internal malloc/free wrappers
with xmalloc and free. Remove conditional in if(foo)free(foo);
situations. Remove bogus
if (sizeof(int) != 4) {
return BZ_CONFIG_ERROR;
}
(...etc...) code and code for handling BZ_CONFIG_ERROR. Someone should
go through and change the applet to use well-defined types when
appropriate - it expects sizeof(short)==2 && sizeof(int)==4. Until
this commit these were explicitly checked for, and the applet would
exit if these types were not the right size. (I think this is wrong
even as an interim solution.)
With gcc 3.1 reduces size of binary on i386-linux by about 700 bytes.
Lightly tested.
|
|
output.
* testsuite/bunzip2/bzcat-does-not-remove-compressed-file: New.
|
|
* testsuite/bunzip2/bunzip2-removes-compressed-file: New.
|
|
(bunzip2_main): Read data from standard input if FILE argument is `-' or
omitted.
* include/usage.h (bunzip2_trivial_usage, bunzip2_full_usage): Rewrite.
* testsuite/bunzip2/bunzip2-reads-from-standard-input: New.
|
|
|
|
binary size.
|
|
|
|
|
|
This code could be improvemed by
1) supporting more options,
2) Creating a shared crc table with gunzip, or perhaps generated on the fly.
3) Removing any remaining unneccessary code (e.g. if (noisy))
|