aboutsummaryrefslogtreecommitdiff
path: root/coreutils/ls.c
AgeCommit message (Collapse)Author
2004-09-24Patch from David Daney to make the -i option work with -l.Glenn L McGrath
2004-08-26Tito writes:Eric Andersen
Hi, I've spent the half night staring at the devilish my_getpwuid and my_getgrgid functions trying to find out a way to avoid actual and future potential buffer overflow problems without breaking existing code. Finally I've found a not intrusive way to do this that surely doesn't break existing code and fixes a couple of problems too. The attached patch: 1) changes the behaviour of my_getpwuid and my_getgrgid to avoid potetntial buffer overflows 2) fixes all occurences of this function calls in tar.c , id.c , ls.c, whoami.c, logger.c, libbb.h. 3) The behaviour of tar, ls and logger is unchanged. 4) The behavior of ps with somewhat longer usernames messing up output is fixed. 5) The only bigger change was the increasing of size of the buffers in id.c to avoid false negatives (unknown user: xxxxxx) with usernames longer than 8 chars. The value i used ( 32 chars ) was taken from the tar header ( see gname and uname). Maybe this buffers can be reduced a bit ( to 16 or whatever ), this is up to you. 6) The increase of size of the binary is not so dramatic: size busybox text data bss dec hex filename 239568 2300 36816 278684 4409c busybox size busybox_fixed text data bss dec hex filename 239616 2300 36816 278732 440cc busybox 7) The behaviour of whoami changed: actually it prints out an username cut down to the size of the buffer. This could be fixed by increasing the size of the buffer as in id.c or avoid the use of my_getpwuid and use getpwuid directly instead. Maybe this colud be also remain unchanged...... Please apply if you think it is ok to do so. The diff applies on today's cvs tarball (2004-08-25). Thanks in advance, Ciao, Tito
2004-07-26BusyBox has no business hard coding the number of major and minor bits for aEric Andersen
dev_t. This is especially important now that the user space concept of a dev_t and the kernel concept of a dev_t are divergant. The only bit of user space allowed to know the number of major and minor bits is include/sys/sysmacros.h (i.e. part of libc). When used with a current C library and a 2.6.x kernel, this fix should allow BusyBox to support wide device major/minor numbers. -Erik
2004-03-27s/fileno\(stdin\)/STDIN_FILENO/gEric Andersen
s/fileno\(stdout\)/STDOUT_FILENO/g
2004-03-23Brian Pomerantz writes:Eric Andersen
I've noticed a bug in the "autowidth" feature more, and is probably in others. The call to the function get_terminal_width_height() passes in a file descriptor but that file descriptor is never used, instead the ioctl() is called with 0. In more_main() the call to get_terminal_width_height() passes 0 as the file descriptor instead of fileno(cin). This isn't a problem when you more a file (e.g. "more /etc/passwd") but when you pipe a file to it (e.g. "cat /etc/passwd | more") the size of the terminal cannot be determined because file descriptor 0 is not a terminal. The fix is simple, I've attached a patch for more.c and get_terminal_width_height.c. BAPper
2004-03-15Remove trailing whitespace. Update copyright to include 2004.Eric Andersen
2004-03-08Fix broken sort order flags.Manuel Novoa III
2004-03-06Patch from Matt Kraai to fix debian bug number 231994.Glenn L McGrath
There was an extra blank line preceding the first directory.
2004-02-05Vladimir N. Oleynik writes:Eric Andersen
Hi, Glenn. Current CVS "ls" applet have small problem: some options ignoring. Last patch attached ;-) --w vodz
2004-01-18Fix a bug where `ls -le` would print the time twice.Glenn L McGrath
2004-01-18Use bb_getopt_ulflags, save 200-300 bytesGlenn L McGrath
2003-11-04Fix oversight with CONFIG_FEATURE_AUTOWIDTH handlingEric Andersen
2003-09-15Be entirely consistant when using ioctl(0, TIOCGWINSZ, &winsize)Eric Andersen
to ensure proper fallback behavior on, i.e. serial consoles. -Erik
2003-07-14Michael Sternberg writes:Eric Andersen
Latest BusyBox from CVS (Jul 7 2003). File coreutils/ls.c "if" at line 970 should be enclosed in #ifdef CONFIG_FEATURE_LS_SORTFILES "if" at line 976 should be enclosed in #ifdef CONFIG_FEATURE_LS_TIMESTAMPS
2003-07-03Patch from Russell Coker:Eric Andersen
I've attached my latest SE Linux patch for busybox against the latest CVS version of busybox.
2003-03-19Major coreutils update.Manuel Novoa III
2003-01-14last_patch75_2 from vodz,Eric Andersen
2003-01-06Correct column width for tab completion and lsGlenn L McGrath
2002-11-28Change if(x)free(x); to free(x);Aaron Lehmann
2002-11-28Use printf instead of fprintf(stdoutGlenn L McGrath
2002-08-22Run through indent, fix BB_ defineGlenn L McGrath
2002-04-27Fix silly combinitorial oversightEric Andersen
2002-04-17ls could mis-color certain entries when previous commandsEric Andersen
had failed. Explicitly 0 out errno to prevent that.
2002-03-20Patch from J.W.Janssen <JanWillem.Janssen@lxtreme.nl> to provideEric Andersen
color ls support, modifed by me to behave properly when not running output to a terminal (i.e. 'ls | more') -Erik
2002-03-08list_single: Declare scratch iff CONFIG_FEATURE_LS_USERNAME is defined.Matt Kraai
2002-03-08* fileutils/ls.c (showfiles): Display multiple short names on a line.Matt Kraai
2001-12-20Remove `== TRUE' tests and convert `!= TRUE' and `== FALSE' tests to use !.Matt Kraai
2001-10-24Major rework of the directory structure and the entire build system.Eric Andersen
-Erik
2001-07-31Make formatting match GNU ls (we were including a spare ' ')Eric Andersen
-Erik
2001-07-22Some patches to make dietlibc work...Eric Andersen
2001-07-19Some adjustments, mostly from David McCullough <davidm@lineo.com> toEric Andersen
make busybox be more uClinux friendly. I also adjusted Config.h for uClinux so it will automagically disable apps the arn't going to work without fork() and such. -Erik
2001-06-30Pad the human readable output for 'ls -sh' to 6 chars, since we willEric Andersen
have numbers printed as XXX.YU, so we need 6 digits not 4. -Erik
2001-06-30ls -s was reporting bytes instead of blocks.Manuel Novoa III
2001-06-25Fix up some warnings that show up on ppcEric Andersen
2001-06-13I reworked make_human_readable_str so it now has a sane interface,Eric Andersen
and then fixed up df, du, and ls to use the new interface. I also fixed up some formatting issues in ls while I was in there. -Erik
2001-05-23Patch from larry to fix some grammar errors.Eric Andersen
2001-04-30Made new xreadlink function for libbb and changed applets to use it instead ofMark Whitley
readlink(2).
2001-04-23Simplify pathname building, in which a bug was noted by Larry Doolittle,Matt Kraai
a patch was provided by Vladimir Oleynik, and am improved patch commited by me.
2001-04-05more FILE_OFFSET_BITS == 64 adjustments.Eric Andersen
2001-04-05A number of cleanups. Now compiles with libc5, glibc, and uClibc. Fix a fewEric Andersen
shadowed variables. Move (almost) all syscalls to libbb/syscalls.c, so I can handle them sanely and all at once. -Erik
2001-04-03Place a temporary bandaid on the ls/du/df human-readable issue. This method isEric Andersen
not going to scale up as well as I would like, and Matt Kraai and I have discussed a better long term solution. But for now this will at least make all the human-readable apps give correct answers. Please test the human readable/non-human readable options on your systems!!! -Erik
2001-03-28Fix ls so it uses make_human_readable_str() the same way alreadyEric Andersen
used by 'du' and 'df'. Now we just need to fix make_human_readable_str so it behaves they way it used to before Matt fixed it.
2001-03-27Applied patch from David Douthitt to fix problem where ls reports half theMark Whitley
file size. Should close bug #1140.
2001-03-09A cleanup patch from Jeff Garzik to static-ify a number ofEric Andersen
namespace polluting things that really should be static.
2001-03-07Some minor cleanups to df.c. Also, with Erik's blessing, changed name ofMark Whitley
'format' function to 'make_human_readable_str'.
2001-03-07Fix up ls.c to ensure human readable works properly in all casesEric Andersen
2001-03-06I made these little simplifications a while back, bug forgot toEric Andersen
check this stuff in. -Erik
2001-02-20Oops. Put time.h after busybox.h, so we can check for BB_FEATURE_LS_TIMESTAMPSEric Andersen
-Erik
2001-02-20It turns out that DODMALLOC was broken when I reorganized busybox.hEric Andersen
header file usage before the 0.49 release. To fix it, I had to move the '#include "busybox.h"' to the end of the list of #include files. -Erik
2001-02-15Fixed 'ls -s' so it actually displays block sizes again.Eric Andersen
-Erik
generated by cgit v1.2.3 (git 2.39.1) at 2024-11-13 23:51:10 +0000