aboutsummaryrefslogtreecommitdiff
path: root/modutils/modprobe.c
AgeCommit message (Collapse)Author
2006-10-03getopt_ulflags -> getopt32.Denis Vlasenko
It is impossible to formulate sane ABI based on size of ulong because it can be 32-bit or 64-bit. Basically it means that you cannot portably use more that 32 option chars in one call anyway... Make it explicit.
2006-08-22Patch from Yann Morin so modprobe won't return failure if the module getsRob Landley
loaded while it's running (ala multi-device hotplug).
2006-08-03Remove xcalloc() and convert its callers to xzalloc(). About half of themRob Landley
were using "1" as one of the arguments anyway, and as for the rest a multiply and a push isn't noticeably bigger than pushing two arguments on the stack.
2006-08-03Remove bb_ prefixes from xfuncs.c (and a few other places), consolidateRob Landley
things like xasprintf() into xfuncs.c, remove xprint_file_by_name() (it only had one user), clean up lots of #includes... General cleanup pass. What I've been doing for the last couple days. And it conflicts! I've removed httpd.c from this checkin due to somebody else touching that file. It builds for me. I have to catch a bus. (Now you know why I'm looking forward to Mercurial.)
2006-07-20Patch from Yann Morin to fix bug 941, underscores in module aliases.Rob Landley
2006-07-19Patch from Yann Morin to look for modules.conf in the right place on 2.6.Rob Landley
Fixes http://bugs.busybox.net/view.php?id=942
2006-06-21Jean Wolter writes: modprobe checks, whether a module is already loaded. The ↵Mike Frysinger
function used for this currently always returns 0.
2006-06-14Attempt at fixing bug 836, vaguely based on patch from somebody namedRob Landley
clausmuus, forwarded to me by Yann E. Morin.
2006-06-14Attempt at fixing bug 815 by upgrading bb_spawn() so that builtins are atRob Landley
the start of the path. (This should be under the same config option as the standalone shell, but right now that's buried in the shell menu.) Also add the ability to specify CONFIG_BUSYBOX_EXEC_PATH with /proc/self/exe as an overrideable default.
2006-06-03- move #include busybox.h to the very top so we pull in the configBernhard Reutner-Fischer
and eventual platform specific includes in early. - remove two supposedly superfluous newlines from ...error_msg() in modprobe and use shorter boilerplate while at it.
2006-06-03- patch from Yann E. Morin: makes modprobe understand shell patternsBernhard Reutner-Fischer
(especially '*') in module aliases, such as: "alias usb:v0582p0075d*dc*dsc*dp*ic*isc*ip* snd_usb_audio" Fixes bug #889 842162 10244 645924 1498330 16dcda busybox.old-4.1.20060603-1948 842178 10244 645924 1498346 16dcea busybox.new-4.1.20060603-1948
2006-05-19- cleanup memory if opening aliases failed and cleanup was requested.Bernhard Reutner-Fischer
2006-05-18Avoid a memory leak pointed out by Lucas C. Villa Real.Rob Landley
2006-05-07Remove bb_strlen() in favor of -fno-builtin-strlen. Saves as many bytesRob Landley
as the old optimization did (actually does slightly better under gcc 4.0), and simplifies the code.
2006-04-10Modprobe update from Ignacio García Pérez, updating support for modprobe.conf.Rob Landley
2006-04-03- make append_option and multiconvert static.Bernhard Reutner-Fischer
2006-03-06Robert P. Day removed 8 gazillion occurrences of "extern" on functionRob Landley
definitions. (That should only be on prototypes.)
2006-02-02destroy bug 679, use getopt_ulflags with new feature: usage option. Removed ↵"Vladimir N. Oleynik"
two strdup
2005-12-16I screwed up the last commit: if dt is null when ENABLE_MULTIPLE_OPTIONS isRob Landley
off, we'd dereference the null. Oops.
2005-12-15Better use of the ENABLE guards.Rob Landley
2005-12-14- remove warning (thanks Yann E. MORIN) and switch to ENABLE_Bernhard Reutner-Fischer
- typo: s/begining/beginning/g
2005-12-13Minor fix: if(CONFIG) breaks the build when that CONFIG is disabled, it hasRob Landley
to be if(ENABLE). (Make allbareconfig is a good testing thing.)
2005-12-12Patch from Yann E. Morin, something to do with bugs 276 and 272.Rob Landley
2005-12-12Change CONFIG_MODPROBE_MULTIPOLE_OPTIONS toRob Landley
CONFIG_FEATURE_MODPROBE_MULTIPLE_OPTIONS.
2005-11-15Yann Morin's modprobe multiple options patch. There's more work to be done,Rob Landley
but let's ship 1.1 first...
2005-08-04applying jim bauer's patch to eliminate modprobe's dependencyPaul Fox
on /bin/sh. bug #8. 0000008: modprobe applet is dependent on having a shell
2005-04-16Patch from Bernhard Fischer to make a bunch of symbols staticEric Andersen
which were otherwise cluttering the global namespace.
2004-09-24Patch from Egor DudaGlenn L McGrath
Attached patch prevents modprobe from trying to call 'insmod (null)' whenever nonexistent module is either passed to modprobe via command line or mentioned in modules.dep this replaces cryptic error sh: Syntax error: word unexpected (expecting ")") with modprobe: module some-module not found. egor.
2004-08-19Patch from Mike Castle to cleanup some modutils issues, inEric Andersen
particular making alias support work better.
2004-08-16Only pass modprobe module params with 2.6.x kernel support.Eric Andersen
-Erik
2004-08-14Christian Ostheimer writes:Eric Andersen
Hello, function build_dep in modprobe.c assumes that dependencies of one module have not more than 255 chars; that is not sufficient in kernel 2.6.7 (alsa sound modules). - Below is a diff that solves the problem for me. With regards, Christian Ostheimer
2004-08-11Patch from Mike Castle, dont print an empty line (patch modified by me toGlenn L McGrath
change formatting).
2004-08-11Patch from Phil Blundellto improve substring matchGlenn L McGrath
2004-08-11Willian Barsse wroteGlenn L McGrath
"There seems to be a slight problem with the "mod_strcmp" function in modprobe.c, it scans for the first occurence of the module name in the "mod_path" variable and expects it to be the last path element. ie /lib/modules/2.4.22-debug/kernel/fs/vfat in my example. The comparison will always fail if mod_path contains another substring matching the module name." Robert McQueen wrote "Although William Barsse's patch fixed mod_strcmp for 2.4 kernels, there was a remaining problem which prevented it from working for me. I've just tracked it down - when you enable kernel 2.6 module support it hard-wired the extension to .ko instead of checking at runtime like the other places where 2.4 differs from 2.6. The attached patch fixes this for me."
2004-08-03William Barsse writes:Eric Andersen
fixes two other issues (plus the previous as well) with a 2.4 kernel : - should be able to modprobe an already loaded module and get 0 return code : # modprobe <something> && modprobe <something> && echo "ok" || echo "failed" .... failed Well, hope this helps and that I didn't screw up again, - William
2004-07-22Patch from Mike Snitzer <snitzer@gmail.com>:Robert Griebl
Support for /etc/modprobe.conf (for 2.6 kernels) should likely be added to bb's modprobe, see attached patch. modprobe.conf is just a (even simpler) variant of modules.conf
2004-06-22Patrick Huesmann writes:Eric Andersen
Hi, There was some problem with busybox modprobe. For details see http://www.busybox.net/lists/busybox/2004-May/011507.html I made a patch against busybox-1.00-pre10 to fix that one. This is a slight variant of Patrick's patch with a slightly cleaner implementation of mod_strcmp() -Erik
2004-04-06Michael Tokarev, mjt at tls dot msk dot ru writes:Eric Andersen
Fix parsing of all tag-value pairs (in modules.conf in particular). Without this fix, code chokes badly on lines where either value or both tag+value are missing, like bare alias line, or alias w/o the value like alias some-module (syntactically incorrect, but no need for coredumps either).
2004-04-06Michael Tokarev, mjt at tls dot msk dot ru writes:Eric Andersen
alias 'off' parsing fix. It is not alias off module it is alias module off
2004-04-06Michael Tokarev, mjt at tls dot msk dot ru writes:Eric Andersen
Initialize all fields of struct dep_t. Without that, e.g. `busybox modprobe -v char-major-10-144' *sometimes* fails this way (strace): write(1, "insmod nvram `\213\f\10\n", 21) = 21 Note the garbage after module name which is taken from the m_options field, which is not initialized in the alias reading/parsing part. (Shell properly complains to this command, telling it can't find the closing backtick)
2004-01-10whitespace cleanupEric Andersen
2004-01-10Woody Suwalski writes:Eric Andersen
I have found the problem in modprobe, so here is the promised patch At the current stage I can use it as modprobe while switching between 2.4 and 2.6 seemlesly...(that is good!)
2004-01-06Woody Suwalski writes:Eric Andersen
accept more then 1 dependency per modules.dep line. Also white space cleanup... I think that parsing still breaks sometimes, but is mostly functional now.
2003-12-24re-indentEric Andersen
2003-12-19Patch from Woody Suwalski:Eric Andersen
Erik, I think we have met online some time ago when I was in Corel/Rebel Netwinder project.... Anyway, I would like to use BB on 2.6.0 initrd. 1.00-pre4 works OK, if insmod is actually presented with a full path to the module. Otherwise - problems (not to mention conflicts when 2.4 modutil is enabled) Here are some patches for insmod and modprobe which try to walk around the default ".o" module format for 2.2/2.4 modules (you have probably noticed it is now .ko in 2.6 ;-)) Trying to steal as little space as possible if 2.6 not enabled... The modprobe is still not perfect on 2.6 - seems to be jamming on some dependencies, but works with some (to be debugged). Anyway after the patches it at least tries to work.... Will there be a 1.00-pre5 coming any time soon? Thanks, Woody
2003-11-14Steven Seeger writes:Eric Andersen
Hey guys. I've found a bug in modprobe where it generates bad strings and makes sytem calls with them. The following patch seems to have fixed the problem. It is rather inherited elsewhere, as there seems to be incorrect entries in the list which results in more dependencies than really exist for a given call to mod_process. But, this patch prevents the bad text from going to the screen. You will notice there are cases where lcmd goes unmodified before calling system. Please consider the following patch. Thanks. -Steve
2003-09-08Busybox modprobe has a couple of irritating quirks:Glenn L McGrath
- attempting to modprobe a module that is already loaded yields "Failed to load module", whereas modutils quietly ignores such a request. - if a module genuinely can't be loaded due to missing symbols or similar problems, modprobe doesn't produce any useful diagnostics because the output from insmod has been redirected to /dev/null. Here's a patch to address these issue Patch by Philip Blundell
2003-06-20Fall back to looking in /lib/modules/modules.dep ifEric Andersen
/lib/modules/<kernel version>/modules.dep is missing
2003-06-20Patch from Andrew Dennison:Eric Andersen
I've had some issues with modprobe which I reported a few months ago. This is still an issue so I decided to sort it out. The attached diff includes the changes against the unstable cvs tree that work for me. Changes are: mod_process() will report success if the module at the head of the list loads successfully. It will also report success if any module unloads successfully. The net result being that modprobe will succeed in the cases outlined below. I've also added error reporting to modprobe -r. Previously it would silently fail (but report success) if the module could not be unloaded. Andrew
2003-03-19Major coreutils update.Manuel Novoa III