aboutsummaryrefslogtreecommitdiff
path: root/modutils
AgeCommit message (Collapse)Author
2004-04-06Michael Tokarev, mjt at tls dot msk dot ru writes:Eric Andersen
Fix parsing of all tag-value pairs (in modules.conf in particular). Without this fix, code chokes badly on lines where either value or both tag+value are missing, like bare alias line, or alias w/o the value like alias some-module (syntactically incorrect, but no need for coredumps either).
2004-04-06Michael Tokarev, mjt at tls dot msk dot ru writes:Eric Andersen
alias 'off' parsing fix. It is not alias off module it is alias module off
2004-04-06Michael Tokarev, mjt at tls dot msk dot ru writes:Eric Andersen
Initialize all fields of struct dep_t. Without that, e.g. `busybox modprobe -v char-major-10-144' *sometimes* fails this way (strace): write(1, "insmod nvram `\213\f\10\n", 21) = 21 Note the garbage after module name which is taken from the m_options field, which is not initialized in the alias reading/parsing part. (Shell properly complains to this command, telling it can't find the closing backtick)
2004-04-06Christian Grigis, christian.grigis at smartdata dot ch writes:Eric Andersen
Hello everyone, Busybox's insmod fails to locate a module when that module is the only one existing in the /lib/modules directory (with a unique name). Example: # find /lib/modules/ -type f /lib/modules/kernel/drivers/char/bios.o # insmod bios insmod: bios.o: no module by that name found # touch /lib/modules/dummy # find /lib/modules/ -type f /lib/modules/kernel/drivers/char/bios.o /lib/modules/dummy # insmod bios Using /lib/modules/kernel/drivers/char/bios.o As long as there is another file in the /lib/modules directory, insmod finds it OK. I tracked the problem down to 'check_module_name_match()' in insmod.c: It returns TRUE when a match is found, and FALSE otherwise. In the case where there is only one module in the /lib/modules directory (or more that one module, but all with the same name), 'recursive_action()' will return TRUE and we end up on line 4196 in 'insmod.c' which returns an error. [The reason it works with more than one module with different names is that in this case there will always be one not matching, 'recursive_action()' will return FALSE and we end up in line 4189.] Now, from the implementation of 'recursive_action()' and from other usages of it (tar.c, etc.), it seems to me that FALSE should be returned to indicate that we want to stop the recursion, so TRUE and FALSE should be inverted in 'check_module_name_match()'. At the same time, 'recursive_action()' continues to recurse even after the recursive call has returned FALSE; again in my understanding and other usages of it, we can safely stop recursing at this point. Here is my patch against 1.00-pre8:
2004-03-19As noted in a patch from Kendrick Hamilton, rmmod was onlyEric Andersen
half way converted, and still used the old delete_module(), call rather than a syscall, in one spot.
2004-03-19Add missing ELFCLASSM for m68kEric Andersen
2004-03-19Only use R_68K_GOTOFF if it is definedEric Andersen
2004-03-15Remove trailing whitespace. Update copyright to include 2004.Eric Andersen
2004-02-18Patch from OpenWrt.Manuel Novoa III
2004-01-10whitespace cleanupEric Andersen
2004-01-10Woody Suwalski writes:Eric Andersen
I have found the problem in modprobe, so here is the promised patch At the current stage I can use it as modprobe while switching between 2.4 and 2.6 seemlesly...(that is good!)
2004-01-06Woody Suwalski writes:Eric Andersen
accept more then 1 dependency per modules.dep line. Also white space cleanup... I think that parsing still breaks sometimes, but is mostly functional now.
2004-01-05Fix broken #elseEric Andersen
2003-12-31Fix debian bug #215612, insmod should be silent on requestGlenn L McGrath
2003-12-24re-indentEric Andersen
2003-12-19Patch from Woody Suwalski:Eric Andersen
Erik, I think we have met online some time ago when I was in Corel/Rebel Netwinder project.... Anyway, I would like to use BB on 2.6.0 initrd. 1.00-pre4 works OK, if insmod is actually presented with a full path to the module. Otherwise - problems (not to mention conflicts when 2.4 modutil is enabled) Here are some patches for insmod and modprobe which try to walk around the default ".o" module format for 2.2/2.4 modules (you have probably noticed it is now .ko in 2.6 ;-)) Trying to steal as little space as possible if 2.6 not enabled... The modprobe is still not perfect on 2.6 - seems to be jamming on some dependencies, but works with some (to be debugged). Anyway after the patches it at least tries to work.... Will there be a 1.00-pre5 coming any time soon? Thanks, Woody
2003-12-11Update modutils with 2.6 module supportEric Andersen
2003-12-04Add (untested) support for cris, based on the (old) busybox insmodManuel Novoa III
that axis distributes.
2003-11-14Steven Seeger writes:Eric Andersen
Hey guys. I've found a bug in modprobe where it generates bad strings and makes sytem calls with them. The following patch seems to have fixed the problem. It is rather inherited elsewhere, as there seems to be incorrect entries in the list which results in more dependencies than really exist for a given call to mod_process. But, this patch prevents the bad text from going to the screen. You will notice there are cases where lcmd goes unmodified before calling system. Please consider the following patch. Thanks. -Steve
2003-10-21Do a better job of dealing with screwy s390 abi changesEric Andersen
2003-10-20ccording to this:Eric Andersen
http://sources.redhat.com/ml/binutils/2003-01/msg00290.html The name R_390_GOTOFF was changed to R_390_GOTOFF32. -Erik
2003-09-08Busybox modprobe has a couple of irritating quirks:Glenn L McGrath
- attempting to modprobe a module that is already loaded yields "Failed to load module", whereas modutils quietly ignores such a request. - if a module genuinely can't be loaded due to missing symbols or similar problems, modprobe doesn't produce any useful diagnostics because the output from insmod has been redirected to /dev/null. Here's a patch to address these issue Patch by Philip Blundell
2003-09-03To load GPLONLY symbols its is required that CHECK_TAINTED_MODULES beGlenn L McGrath
enabled, if not GPLONLY symbols are ignored.
2003-08-31"insmod caches the symbolname in a variable before modifying it and usesGlenn L McGrath
the cached value afterwards." - Jean Wolter
2003-08-30handle GPLONLY symbolsGlenn L McGrath
2003-08-13Patch from Paul Mundt (lethal) adding sh64 insmod support for busyboxEric Andersen
2003-08-06Steven Scholz writes:Eric Andersen
the output of lsmod (busybox-1.00-pre2) contains IMHO one "\n" too much when using CONFIG_FEATURE_CHECK_TAINTED_MODULE: ~ # lsmod Module Size Used by Tainted: P ds 8364 1 m8xx_pcmcia 5388 1 pcmcia_core 40736 0 [ds m8xx_pcmcia] and this patch from Steven fixes the problem
2003-07-22Document CONFIG_FEATURE_INSMOD_LOADINKMEMEric Andersen
2003-07-22Patch from Terje Kvernes adding quite a lot of missing documentationEric Andersen
2003-07-22Remove remaining libc5 support codeEric Andersen
2003-07-14Update a bunch of docs. Run a script to update my email addr.Eric Andersen
2003-07-14Patch from Thomas Cameron:Eric Andersen
Hello all, This patch adds more "Help" text to the config system. Almost all applets now have a help entry. Also, I cleaned up the spacing of the existing text so that things are consistent. This patch is against this morning's CVS. Thomas Cameron CEI Systems, Inc.
2003-07-05Patch from Kent Robotti adding a bunch of needed docs!Eric Andersen
-Erik
2003-06-20Fall back to looking in /lib/modules/modules.dep ifEric Andersen
/lib/modules/<kernel version>/modules.dep is missing
2003-06-20Patch from Andrew Dennison:Eric Andersen
I've had some issues with modprobe which I reported a few months ago. This is still an issue so I decided to sort it out. The attached diff includes the changes against the unstable cvs tree that work for me. Changes are: mod_process() will report success if the module at the head of the list loads successfully. It will also report success if any module unloads successfully. The net result being that modprobe will succeed in the cases outlined below. I've also added error reporting to modprobe -r. Previously it would silently fail (but report success) if the module could not be unloaded. Andrew
2003-03-30Rename, to specify kernelGlenn L McGrath
2003-03-19Major coreutils update.Manuel Novoa III
2003-03-13Fix obviously wrong names from older busyboxEric Andersen
2003-01-23Patch from Jason McMullan @ linuxcare.com adding insmodEric Andersen
support for s390 systems.
2003-01-23Patch from Artem Egorkine to support the -m optionEric Andersen
2003-01-23Patch from Joel Vallier to add modules symbols to the kernel symbolEric Andersen
table in order to obtain better debug output from ksymoops.
2003-01-11Patch from Robert Schwebel fixing a missing \nEric Andersen
2002-12-14rmmod -a removed modules recursivelyTim Riker
2002-12-13cleanupTim Riker
2002-12-05Yet another major rework of the BusyBox config system, using the considerablyEric Andersen
modified Kbuild system I put into uClibc. With this, there should be no more need to modify Rules.mak since I've moved all the interesting options into the config system. I think I've got everything updated, but you never know, I may have made some mistakes, so watch closely. -Erik
2002-12-03print an error message if we can't load a moduleRobert Griebl
2002-11-28Change if(x)free(x); to free(x);Aaron Lehmann
2002-10-18Fix needless formatting differences vs modutilsEric Andersen
2002-10-12Doh! I screwed up applying vodz' patch.Eric Andersen
-Erik
2002-10-10last_patch61 from vodz:Eric Andersen
New complex patch for decrease size devel version. Requires previous patch. Also removed small problems from dutmp and tar applets. Also includes vodz' last_patch61_2: Last patch correcting comment for #endif and more integrated with libbb (very reduce size if used "cat" applet also). Requires last_patch61 for modutils/config.in.
generated by cgit v1.2.3 (git 2.39.1) at 2024-06-12 15:24:00 +0000