aboutsummaryrefslogtreecommitdiff
path: root/networking/ftpd.c
AgeCommit message (Collapse)Author
2009-03-16ftpd: dont use fdprintf for simple status messagesDenis Vlasenko
function old new delta ftpd_main 2025 2055 +30 cmdio_write_ok 17 25 +8 cmdio_write_error 17 25 +8 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 3/0 up/down: 46/0) Total: 46 bytes
2009-03-16ftpd: simplify PORT check by assuming IP = peer's IP.Denis Vlasenko
Should be as safe as before this change. function old new delta ftpd_main 2115 2025 -90
2009-03-16ftpd: add idle and absolute timeouts. This is a security issue,Denis Vlasenko
otherwise ftpd may end up hanging indefinitely. function old new delta timeout_handler - 110 +110 ftpd_main 2019 2115 +96 packed_usage 25662 25685 +23 handle_upload_common 306 322 +16 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 3/0 up/down: 245/0) Total: 245 bytes
2009-03-16ftpd: security tightened up:Denis Vlasenko
PORT is not allowed on !IPv4 PORT must have IP == peer's IP upload is allowed only into regular files function old new delta ftpd_main 1815 2019 +204 handle_upload_common 260 306 +46 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/0 up/down: 250/0) Total: 250 bytes
2009-03-15ftpd: fix the bug where >2GB file ops report errors;Denis Vlasenko
make a few simplifications; add TODOs. function old new delta port_or_pasv_was_seen - 37 +37 get_remote_transfer_fd 104 109 +5 handle_upload_common 265 260 -5 handle_dir_common 228 223 -5 popen_ls 211 203 -8 ftpd_main 1825 1815 -10 data_transfer_checks_ok 37 - -37 ------------------------------------------------------------------------------ (add/remove: 1/1 grow/shrink: 1/4 up/down: 42/-65) Total: -23 bytes
2009-03-11ftpd: stop unconditional logging to syslog. This was the only appletDenis Vlasenko
which was doing it. Added option -S to enable it when desired. function old new delta packed_usage 25647 25666 +19 ftpd_main 1826 1825 -1
2009-03-09ftpd: add LOG_NDELAY to openlogDenis Vlasenko
2009-03-09ftpd: reuse ls applet for LIST/NLST/STAT generationDenis Vlasenko
function old new delta popen_ls - 211 +211 ftpd_main 1760 1826 +66 handle_dir_common 199 228 +29 get_remote_transfer_fd 89 104 +15 replace_char 30 34 +4 handle_upload_common 263 265 +2 bind_for_passive_mode 129 121 -8 cmdio_write 84 62 -22 escape_text 166 136 -30 init_data_sock_params 81 - -81 ftpdataio_dispose_transfer_fd 87 - -87 write_dirstats 149 - -149 write_filestats 603 - -603 ------------------------------------------------------------------------------ (add/remove: 1/4 grow/shrink: 11/5 up/down: 384/-986) Total: -602 bytes text data bss dec hex filename 808804 476 7864 817144 c77f8 busybox_old 808156 476 7864 816496 c7570 busybox_unstripped
2009-03-09ftpd: EPSV and SIZE support. Tested to work on IPv6 too.Denis Vlasenko
libbb: str2sockaddr shuld accept [IPv6] addr without port - wget 'ftp://[::1]/file' needs that to work. function old new delta bind_for_passive_mode - 129 +129 get_nport - 30 +30 ftpd_main 1731 1760 +29 str2sockaddr 412 431 +19 ------------------------------------------------------------------------------ (add/remove: 2/0 grow/shrink: 2/0 up/down: 207/0) Total: 207 bytes text data bss dec hex filename 808568 476 7864 816908 c770c busybox_old 808804 476 7864 817144 c77f8 busybox_unstripped
2009-03-09ftp: reduce amount of realloc's done in cmdio_writeDenis Vlasenko
text data bss dec hex filename 808562 476 7864 816902 c7706 busybox_old 808568 476 7864 816908 c770c busybox_unstripped
2009-03-09ftpd: code shrinkDenis Vlasenko
2009-03-09ftpd: code shrinkDenis Vlasenko
2009-03-09ftp: code shrinkDenis Vlasenko
text data bss dec hex filename 809078 476 7864 817418 c790a busybox_old 808590 476 7864 816930 c7722 busybox_unstripped
2009-03-09ftpd: code shuffled a bit, added commentsDenis Vlasenko
2009-03-09ftpd: add commentDenis Vlasenko
2009-03-09ftpd: further code shrinkDenis Vlasenko
function old new delta port_pasv_cleanup - 50 +50 replace_char - 30 +30 ftp_write_str_common 102 104 +2 handle_dir_common 209 204 -5 ftpd_main 1990 1970 -20 port_cleanup 23 - -23 pasv_cleanup 28 - -28 handle_upload_common 320 273 -47 ------------------------------------------------------------------------------ (add/remove: 2/2 grow/shrink: 1/3 up/down: 82/-123) Total: -41 bytes
2009-03-09*: move get_sock_lsa and xwrite_str to libbb, use where appropriateDenis Vlasenko
function old new delta get_sock_lsa - 72 +72 buffer_fill_and_print 179 196 +17 parse_expr 824 832 +8 read_base64 343 348 +5 nameval 202 206 +4 fbset_main 1694 1698 +4 expand 1849 1853 +4 udhcp_send_kernel_packet 249 252 +3 udhcp_get_option 223 222 -1 chat_main 1246 1245 -1 pack_gzip 1661 1659 -2 doset 299 297 -2 bb__parsespent 119 117 -2 test_main 260 257 -3 qgravechar 109 106 -3 tcpudpsvd_main 1834 1830 -4 sysctl_display_all 589 580 -9 xopen_xwrite_close 44 33 -11 prs 30 18 -12 find_main 418 406 -12 full_write2_str 25 12 -13 adduser_main 667 654 -13 evaltreenr 817 802 -15 evaltree 817 802 -15 tftpd_main 526 493 -33 ftpd_main 2050 1990 -60 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 7/18 up/down: 117/-211) Total: -94 bytes
2009-03-08ftpd: code chrink, fixed some minor bugsDenis Vlasenko
ls: update comment *: openlog fixes (added LOG_PID, set LOG_DAEMON as appropriate) function old new delta xwrite_str - 26 +26 cmdio_write_ok - 15 +15 handle_cwd 40 45 +5 packed_usage 25668 25670 +2 cmdio_write_raw 7 9 +2 handle_upload_common 322 320 -2 udhcpd_main 1375 1372 -3 udhcpc_main 2362 2359 -3 port_cleanup 27 23 -4 handle_dir_common 221 209 -12 str_netfd_write 26 - -26 cmdio_get_cmd_and_arg 122 - -122 ftpd_main 2208 2050 -158 ------------------------------------------------------------------------------ text data bss dec hex filename 809933 476 7864 818273 c7c61 busybox_old 809199 476 7864 817539 c7983 busybox_unstripped
2009-03-08adding forgotten new fileDenis Vlasenko