aboutsummaryrefslogtreecommitdiff
path: root/networking/ifupdown.c
AgeCommit message (Collapse)Author
2004-07-23Patch from Manousaridis Angelos to bring dhclient down more elegentlyGlenn L McGrath
2004-07-21Patch from Mike Snitzer to fix return codes.Glenn L McGrath
"I have a need to _really_ know if the interface was properly configured via ifup so I made busybox's ifupdown pass the return codes through rather than dropping them on the floor." "All the functions in ifupdown.c return 1 on success and 0 on failure (which happens to the opposite of standard practices but whatever). So it is important for all these functions to not blindly return 1." "The problem with blindly returning ret, even if it is != 1, is the callers expect a 0 or 1 and accumulate the return codes. So a function that makes 3 calls to execute will have a value of 3 accumulated. That value of 1 (success) was almost always returned even if 1 of the commands in the command sequence failed. The attached patch fixes the lack of checking to verify thar result == expected_reult."
2004-07-21Patch from Mike Snitzer, bring down dhclient using its correct pid, fixGlenn L McGrath
a grammatical error.
2004-07-20Prevent "`bootp_down' was declared implicitly `extern' and later `static'" ↵Eric Andersen
warning
2004-06-29Paul Fox writes:Eric Andersen
hi -- working with ifupdown, i've found a couple of buglets -- the wrong string is passed to an error message. paul
2004-04-25Update my email address, document some of my tasks in the AUTHORS fileGlenn L McGrath
2004-04-12Eric Spakman noticed that ifdown' will attempt to run 'ifconfig'Eric Andersen
even if built with CONFIG_FEATURE_IFUPDOWN_IP when shutting down a dhcp connection.
2004-03-15Remove trailing whitespace. Update copyright to include 2004.Eric Andersen
2003-12-19Manousaridis Angelos writes:Eric Andersen
Hello, I have been using busybox for some time now, for an ARM based platform. I was very pleased when I tried the 1.00preX series, with all the new utilities and daemons. I found out that the ifupdown in busybox does not behave exaclty like the debian version. Then the pre-up script fails, the interface is getting up. Also when the post-up script fails the return value is ignored. Actually everything is always run and the return value is always true. I looked at the original implementation from debian and fixed the busybox version to do the same. A patch is attached if anyone is interested.
2003-09-12As vodz just pointed out, I screwup up the call to bb_xasprintf!Eric Andersen
2003-09-12Invoke run-parts on /etc/network/if-*.d per the behavior ofEric Andersen
the upstream ifupdown code...
2003-09-02move all "-/bin/sh" "/bin/sh" and "sh" to libbb/messages.c file as oneGlenn L McGrath
constant. Vodz last_patch_107
2003-08-29label's dont work in v4 tunnels, patch by Eric SpakmanGlenn L McGrath
2003-08-06Eric Spakman writes:Eric Andersen
The attached patch adds "mtu" and "hwaddress" to the inet6 method and "mtu", "hwaddr" and "pointopoint" to the inet4 method (just like in the ifupdown part). Note: "hwaddress" can't be used with the busybox ip applet (this function isn't implemented in bb ip yet), but it can be of use with an external "full blown" ip package. The patch also removes "label" from the loopback configuration, labels (subinterfaces) aren't used with loopback interfaces. It further solves a problem in the bootp method, "ifconfig down %interface%" should be "ifconfig %interface% down" and it's now also possible to use ip with bootp. The patch is fully tested with both busybox ip and "stand-alone" ip and I didn't saw any problems.
2003-07-30Eric Spakman writes:Eric Andersen
The recent changes in ifupdown where all calls to 'ip link set' and 'ip addr set' are swapped give some problems with v4tunnels. For plain ipv4 and ipv6 interfaces it works correct, other methods not tried. The patch below change the behaviour back for v4tunnels only. Without the patch the following errors are shown: RTNETLINK answers: Network is down RTNETLINK answers: No route to host and the tunnel is not fully brought up With this patch all works as expected.
2003-07-29Match up interfacesEric Andersen
2003-07-29Bruno Randolf writes:Eric Andersen
this patch fixes run_parts when it's called by ifupdown. 1) argv has to be a NULL terminated char* array, not just a string. 2) run_parts now explicitly sets the environment. this environment is populated from the /etc/network/interfaces config file and is needed by the scripts in /etc/network/if-pre-up.d/. when run-parts is called from the command line the environment is taken from the current process. Vladimir Oleynik then wrote: You can simplify this if use: + bb_xasprintf(&buf[0], "/etc/network/if-%s.d", opt); + buf[1] = NULL; + + run_parts(&buf, 2, environ); + free(buf[0]); --w vodz
2003-07-03Patch from Lars Kellogg-Stedman:Eric Andersen
Erik, et al. The attached patch makes the following changes to networking/ifupdown.c: (1) It swaps all calls to 'ip link set' and 'ip addr set'. This solves two problems: (a) Calling 'ip link set <dev> up' before assigning an address generates an error message, and (b) Under User Mode Linux, running in with ethernet interfaces in daemon mode, the MAC address for an interface is selected based on the IP address assigned to that interface. If the interface is brought up before being assigned an IP address, it gets a null MAC. (2) It further cleans up run_mapping(). This patch is against ifupdown.c revision 1.25. -- Lars
2003-06-20Fixup whitespace handing, fixing some annoying behavior andEric Andersen
a couple of segfaults
2003-06-05Patch from Lars Kellogg-Stedman, lars at larsshack.org, toEric Andersen
make ifupdown's mapping function work as documented.
2003-04-19Patch from David Updegraff to avoid corrupting memory while parsing theEric Andersen
networks/iterfaces file with next_word routine. Without this, next_word increments one beyond the end of the string.
2003-04-02Yet another rather large face lift. It now works for me as expected.Eric Andersen
-Erik
2003-03-19Major coreutils update.Manuel Novoa III
2003-02-03Fix a couple more ifupdown bugsEric Andersen
2003-01-27This seems sufficient for ifup and ifdown to actually workEric Andersen
as advertised. Works for me (at least with glibc)
2003-01-20New test mode that allows run_parts to fail silently if the directoryGlenn L McGrath
is not found. Patch from Bastian Blank
2003-01-14Fix leading spaces bug, free line buffer, redo next_word, save someGlenn L McGrath
space.
2003-01-13Option to allow ifupdown use ip commands instead of ifconfig, add flushGlenn L McGrath
command to ipaddr, patch by Bastian Blank
2002-12-08Start to cleanup handling of the state file, save some space and uses linked ↵Glenn L McGrath
lists.
2002-12-07Differentiate struct and type namesGlenn L McGrath
2002-12-07Fix command that brings down loopbackGlenn L McGrath
2002-12-06Use libbb/get_line_from_file, change default state file locationGlenn L McGrath
2002-12-06Make mapping a config option again to save space, turn off file locking, do ↵Glenn L McGrath
we really need it ?
2002-12-06Fix bug that stoped -a workingGlenn L McGrath
2002-11-26Fix simple syntax errorGlenn L McGrath
2002-11-19Dont use xargsGlenn L McGrath
2002-11-19dont use the -i option of xargsGlenn L McGrath
2002-11-17Remove mapping option, its should always be usedGlenn L McGrath
2002-11-11Make ifupdown use internal run_partsGlenn L McGrath
2002-11-11Move awk from textutils to editors. Cleanup run-parts, saves 200 bytes, ↵Glenn L McGrath
moves the guts of run_parts to libbb to be used by ifupdown.
2002-11-10Fixup a previous defineGlenn L McGrath
2002-11-10Make mapping support a definable feature, saves 1.6kBGlenn L McGrath
2002-11-09debian compatable ifup and ifdown commandsGlenn L McGrath