From 87b49beeda51ef708e5b83c908edeab1ca88339b Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Fri, 14 Dec 2018 16:24:01 +0100 Subject: bc: tweak bc_num_parseDecimal() for readability, logic is not changed function old new delta zbc_program_num 836 835 -1 Signed-off-by: Denys Vlasenko --- miscutils/bc.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/miscutils/bc.c b/miscutils/bc.c index 547af8eaf..2e8d04460 100644 --- a/miscutils/bc.c +++ b/miscutils/bc.c @@ -2334,13 +2334,13 @@ static void bc_num_parseDecimal(BcNum *n, const char *val) n->num[n->len] = val[i] - '0'; ++n->len; skip_dot: - if ((ssize_t)--i == (ssize_t)-1) break; - if (val[i] == '.') goto skip_dot; + if (i == 0) break; + if (val[--i] == '.') goto skip_dot; } break; } } - // if this is reached, the value is entirely zero + // if for() exits without hitting if(), the value is entirely zero } // Note: n is already "bc_num_zero()"ed, -- cgit v1.2.3