From 9c8e94bc0a3836dd6b8acbcf1fa88283a0a3c148 Mon Sep 17 00:00:00 2001 From: Ingo van Lil Date: Fri, 5 Jan 2018 15:04:23 +0100 Subject: ash: fail if 'shift' operand is out of range If the numeric argument passed to ash's 'shift' built-in is greater than '$#' the command performs no operation and exits successfully. It should return a non-zero exit code instead: http://pubs.opengroup.org/onlinepubs/9699919799/utilities/V3_chap02.html#shift This is consistent with bash and hush. function old new delta shiftcmd 122 120 -2 Signed-off-by: Ingo van Lil Signed-off-by: Denys Vlasenko --- shell/ash.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/shell/ash.c b/shell/ash.c index dfb7d4d8e..b73a79975 100644 --- a/shell/ash.c +++ b/shell/ash.c @@ -10858,7 +10858,7 @@ shiftcmd(int argc UNUSED_PARAM, char **argv) if (argv[1]) n = number(argv[1]); if (n > shellparam.nparam) - n = 0; /* bash compat, was = shellparam.nparam; */ + return 1; INT_OFF; shellparam.nparam -= n; for (ap1 = shellparam.p; --n >= 0; ap1++) { -- cgit v1.2.3