From d16e612c93d1a698c1a9d931b786cf3500996ae3 Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Fri, 11 Aug 2017 15:41:39 +0200 Subject: hush: fix redirect code (was using uninitialized variables) Signed-off-by: Denys Vlasenko --- shell/hush.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/shell/hush.c b/shell/hush.c index dc05f24b9..1e58d71e0 100644 --- a/shell/hush.c +++ b/shell/hush.c @@ -6741,7 +6741,8 @@ static struct squirrel *add_squirrel(struct squirrel *sq, int fd, int avoid_fd) int moved_to; int i; - if (sq) for (i = 0; sq[i].orig_fd >= 0; i++) { + i = 0; + if (sq) for (; sq[i].orig_fd >= 0; i++) { /* If we collide with an already moved fd... */ if (fd == sq[i].moved_to) { sq[i].moved_to = fcntl_F_DUPFD(sq[i].moved_to, avoid_fd); @@ -6769,7 +6770,8 @@ static struct squirrel *add_squirrel_closed(struct squirrel *sq, int fd) { int i; - if (sq) for (i = 0; sq[i].orig_fd >= 0; i++) { + i = 0; + if (sq) for (; sq[i].orig_fd >= 0; i++) { /* If we collide with an already moved fd... */ if (fd == sq[i].orig_fd) { /* Examples: -- cgit v1.2.3