From d1b845706df2aa819babe74cb0b9b15c13da6b16 Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Wed, 28 Mar 2018 18:42:54 +0200 Subject: hush: add a FIXME comment Signed-off-by: Denys Vlasenko --- shell/hush.c | 6 ++++++ 1 file changed, 6 insertions(+) diff --git a/shell/hush.c b/shell/hush.c index 012ec219f..e6dd1bc3d 100644 --- a/shell/hush.c +++ b/shell/hush.c @@ -8173,6 +8173,12 @@ static NOINLINE int run_pipe(struct pipe *pi) rcode = 1; /* exitcode if redir failed */ if (setup_redirects(command, &squirrel) == 0) { debug_printf_exec(": run_list\n"); +//FIXME: we need to pass squirrel down into run_list() +//for SH_STANDALONE case, or else this construct: +// { find /proc/self/fd; true; } >FILE; cmd2 +//has no way of closing saved fd#1 for "find", +//and in SH_STANDALONE mode, "find" is not execed, +//therefore CLOEXEC on saved fd does not help. rcode = run_list(command->group) & 0xff; } restore_redirects(squirrel); -- cgit v1.2.3