From c066472b0cfba62260ccb86d567a11c8b3d395e3 Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Sat, 2 Jan 2010 18:49:22 +0100 Subject: *: do not assign to stdout/stderr, it's not portable. Based on patch by Aaron Carroll function old new delta time_main 1062 1052 -10 cpio_main 563 549 -14 Signed-off-by: Denys Vlasenko --- archival/cpio.c | 5 +---- 1 file changed, 1 insertion(+), 4 deletions(-) (limited to 'archival/cpio.c') diff --git a/archival/cpio.c b/archival/cpio.c index 41aeef171..f139f3130 100644 --- a/archival/cpio.c +++ b/archival/cpio.c @@ -354,10 +354,7 @@ int cpio_main(int argc UNUSED_PARAM, char **argv) if (*cpio_fmt != 'n') /* we _require_ "-H newc" */ bb_show_usage(); if (opt & CPIO_OPT_FILE) { - fclose(stdout); - stdout = fopen_for_write(cpio_filename); - /* Paranoia: I don't trust libc that much */ - xdup2(fileno(stdout), STDOUT_FILENO); + xmove_fd(xopen3(cpio_filename, O_WRONLY | O_CREAT | O_TRUNC, 0666), STDOUT_FILENO); } dump: return cpio_o(); -- cgit v1.2.3