From 74324c86663f57a19c1de303ee8c8e5449db9ef2 Mon Sep 17 00:00:00 2001 From: Denis Vlasenko Date: Mon, 4 Jun 2007 10:16:52 +0000 Subject: Audit bb_common_bufsiz usage, add script which looks for misuse. tr: stop using globals needlessly. code: -103 bytes --- coreutils/catv.c | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) (limited to 'coreutils/catv.c') diff --git a/coreutils/catv.c b/coreutils/catv.c index 2d2229f7f..cc61233e1 100644 --- a/coreutils/catv.c +++ b/coreutils/catv.c @@ -33,13 +33,14 @@ int catv_main(int argc, char **argv) else for (;;) { int i, res; - res = read(fd, bb_common_bufsiz1, sizeof(bb_common_bufsiz1)); +#define read_buf bb_common_bufsiz1 + res = read(fd, read_buf, COMMON_BUFSIZE); if (res < 0) retval = EXIT_FAILURE; if (res < 1) break; for (i = 0; i < res; i++) { - char c = bb_common_bufsiz1[i]; + char c = read_buf[i]; if (c > 126 && (flags & CATV_OPT_v)) { if (c == 127) { -- cgit v1.2.3