From 399d2b5c24aaa059104a89058c7d4c8b97f41629 Mon Sep 17 00:00:00 2001 From: Rob Landley Date: Thu, 25 May 2006 23:02:40 +0000 Subject: Rich Felker suggested removing dprintf() from watch, and one thing led to another... This adds bb_xspawn() support, which does vfork/exec. (I don't know why using a static instead of a local adds ~40 bytes, but using the local doesn't work...) --- coreutils/watch.c | 82 ++++++++++++++----------------------------------------- 1 file changed, 21 insertions(+), 61 deletions(-) (limited to 'coreutils/watch.c') diff --git a/coreutils/watch.c b/coreutils/watch.c index 9e0c54c7f..b783d34de 100644 --- a/coreutils/watch.c +++ b/coreutils/watch.c @@ -4,20 +4,7 @@ * * Copyright (C) 2001 by Michael Habermann * - * This program is free software; you can redistribute it and/or modify - * it under the terms of the GNU General Public License as published by - * the Free Software Foundation; either version 2 of the License, or - * (at your option) any later version. - * - * This program is distributed in the hope that it will be useful, - * but WITHOUT ANY WARRANTY; without even the implied warranty of - * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the GNU - * General Public License for more details. - * - * You should have received a copy of the GNU General Public License - * along with this program; if not, write to the Free Software - * Foundation, Inc., 59 Temple Place, Suite 330, Boston, MA 02111-1307 USA - * + * Licensed under GPLv2 or later, see file LICENSE in this tarball for details. */ /* BB_AUDIT SUSv3 N/A */ @@ -41,23 +28,18 @@ int watch_main(int argc, char **argv) { - const int header_len = 40; - time_t t; - pid_t pid; + int width, len; unsigned period = 2; - int old_stdout; - int len, len2; - char **watched_argv; - char header[header_len + 1]; + char **watched_argv, *header; - if (argc < 2) { - bb_show_usage(); - } + if (argc < 2) bb_show_usage(); + + get_terminal_width_height(1, &width, 0); + header = xzalloc(width--); /* don't use getopt, because it permutes the arguments */ ++argv; - if ((argc > 3) && !strcmp(*argv, "-n") - ) { + if ((argc > 3) && !strcmp(*argv, "-n")) { period = bb_xgetularg10_bnd(argv[1], 1, UINT_MAX); argv += 2; } @@ -65,44 +47,22 @@ int watch_main(int argc, char **argv) /* create header */ - len = snprintf(header, header_len, "Every %ds:", period); - /* Don't bother checking for len < 0, as it should never happen. - * But, just to be prepared... */ - assert(len >= 0); - do { - len2 = strlen(*argv); - if (len + len2 >= header_len-1) { - break; - } - header[len] = ' '; - memcpy(header+len+1, *argv, len2); - len += len2+1; - } while (*++argv); - - header[len] = 0; - - /* thanks to lye, who showed me how to redirect stdin/stdout */ - old_stdout = dup(STDOUT_FILENO); + len = snprintf(header, width, "Every %ds:", period); + while (*argv && len 0) { - //parent - wait(0); - sleep(period); - } else if (0 == pid) { - //child - dup2(old_stdout, STDOUT_FILENO); - execvp(*watched_argv, watched_argv); - bb_perror_msg_and_die("%s", *watched_argv); - } else { - bb_perror_msg_and_die("vfork"); - } + waitpid(bb_xspawn(watched_argv),0,0); + sleep(period); } } -- cgit v1.2.3