From 8d9f495d68664017e0b87f2c0c2d0eae9f3c4836 Mon Sep 17 00:00:00 2001 From: Denis Vlasenko Date: Sun, 8 Apr 2007 15:08:42 +0000 Subject: getopt32: fix llist_t options ordering. llist_rev is not unused. function old new delta tar_main 705 695 -10 sort_main 928 918 -10 decode_format_string 886 876 -10 run_parts_main 197 185 -12 ps_main 513 500 -13 wget_main 2764 2750 -14 awk_main 1014 1000 -14 od_main 2886 2866 -20 llist_rev 25 - -25 ------------------------------------------------------------------------------ (add/remove: 0/1 grow/shrink: 0/8 up/down: 0/-128) Total: -128 bytes --- debianutils/run_parts.c | 3 --- 1 file changed, 3 deletions(-) (limited to 'debianutils/run_parts.c') diff --git a/debianutils/run_parts.c b/debianutils/run_parts.c index 873263a22..eb2fb94b3 100644 --- a/debianutils/run_parts.c +++ b/debianutils/run_parts.c @@ -131,9 +131,6 @@ int run_parts_main(int argc, char **argv) */ umask(xstrtoul_range(umask_p, 8, 0, 07777)); } -//XXX: FIXME: reverse the list before handing it over to the user. -//XXX: FIXME: The common case seems to be to use the order given by the user - arg_list = llist_rev(arg_list); /* XXX: getopt32 appends them */ for (tmp = 1; arg_list; arg_list = arg_list->link, tmp++) G.cmd[tmp] = arg_list->data; /* G.cmd[tmp] = NULL; - G is already zeroed out */ -- cgit v1.2.3