From 8d9f495d68664017e0b87f2c0c2d0eae9f3c4836 Mon Sep 17 00:00:00 2001 From: Denis Vlasenko Date: Sun, 8 Apr 2007 15:08:42 +0000 Subject: getopt32: fix llist_t options ordering. llist_rev is not unused. function old new delta tar_main 705 695 -10 sort_main 928 918 -10 decode_format_string 886 876 -10 run_parts_main 197 185 -12 ps_main 513 500 -13 wget_main 2764 2750 -14 awk_main 1014 1000 -14 od_main 2886 2866 -20 llist_rev 25 - -25 ------------------------------------------------------------------------------ (add/remove: 0/1 grow/shrink: 0/8 up/down: 0/-128) Total: -128 bytes --- libbb/llist.c | 23 ++++++++++++----------- 1 file changed, 12 insertions(+), 11 deletions(-) (limited to 'libbb/llist.c') diff --git a/libbb/llist.c b/libbb/llist.c index 2b34f762c..706751447 100644 --- a/libbb/llist.c +++ b/libbb/llist.c @@ -14,7 +14,7 @@ #include "libbb.h" /* Add data to the start of the linked list. */ -void llist_add_to(llist_t ** old_head, void *data) +void llist_add_to(llist_t **old_head, void *data) { llist_t *new_head = xmalloc(sizeof(llist_t)); @@ -24,7 +24,7 @@ void llist_add_to(llist_t ** old_head, void *data) } /* Add data to the end of the linked list. */ -void llist_add_to_end(llist_t ** list_head, void *data) +void llist_add_to_end(llist_t **list_head, void *data) { llist_t *new_item = xmalloc(sizeof(llist_t)); @@ -43,7 +43,7 @@ void llist_add_to_end(llist_t ** list_head, void *data) } /* Remove first element from the list and return it */ -void *llist_pop(llist_t ** head) +void *llist_pop(llist_t **head) { void *data, *next; @@ -81,7 +81,7 @@ void llist_unlink(llist_t **head, llist_t *elm) /* Recursively free all elements in the linked list. If freeit != NULL * call it on each datum in the list */ -void llist_free(llist_t * elm, void (*freeit) (void *data)) +void llist_free(llist_t *elm, void (*freeit) (void *data)) { while (elm) { void *data = llist_pop(&elm); @@ -91,18 +91,19 @@ void llist_free(llist_t * elm, void (*freeit) (void *data)) } } -/* Reverse list order. Useful since getopt32 saves option params - * in reverse order */ -llist_t *llist_rev(llist_t * list) +#ifdef UNUSED +/* Reverse list order. */ +llist_t *llist_rev(llist_t *list) { - llist_t *new = NULL; + llist_t *rev = NULL; while (list) { llist_t *next = list->link; - list->link = new; - new = list; + list->link = rev; + rev = list; list = next; } - return new; + return rev; } +#endif -- cgit v1.2.3