From 8762512fdb088acefb9f3ea5f7b1e1bf2d336ff3 Mon Sep 17 00:00:00 2001 From: Rostislav Skudnov Date: Wed, 1 Feb 2017 18:35:13 +0000 Subject: Replace int -> uint to avoid signed integer overflow An example of such an error (should be compiled with DEBUG_SANITIZE): runtime error: left shift of 1 by 31 places cannot be represented in type 'int' Signed-off-by: Rostislav Skudnov Signed-off-by: Denys Vlasenko --- libbb/crc32.c | 2 +- libbb/getopt32.c | 4 ++-- libbb/pw_encrypt.c | 2 +- 3 files changed, 4 insertions(+), 4 deletions(-) (limited to 'libbb') diff --git a/libbb/crc32.c b/libbb/crc32.c index ac9836cc9..0711ca84e 100644 --- a/libbb/crc32.c +++ b/libbb/crc32.c @@ -24,7 +24,7 @@ uint32_t* FAST_FUNC crc32_filltable(uint32_t *crc_table, int endian) { uint32_t polynomial = endian ? 0x04c11db7 : 0xedb88320; uint32_t c; - int i, j; + unsigned i, j; if (!crc_table) crc_table = xmalloc(256 * sizeof(uint32_t)); diff --git a/libbb/getopt32.c b/libbb/getopt32.c index 15b6efc09..497fc016f 100644 --- a/libbb/getopt32.c +++ b/libbb/getopt32.c @@ -404,7 +404,7 @@ getopt32(char **argv, const char *applet_opts, ...) if (c >= 32) break; on_off->opt_char = *s; - on_off->switch_on = (1 << c); + on_off->switch_on = (1U << c); if (*++s == ':') { on_off->optarg = va_arg(p, void **); if (s[1] == '+' || s[1] == '*') { @@ -454,7 +454,7 @@ getopt32(char **argv, const char *applet_opts, ...) if (c >= 32) break; on_off->opt_char = l_o->val; - on_off->switch_on = (1 << c); + on_off->switch_on = (1U << c); if (l_o->has_arg != no_argument) on_off->optarg = va_arg(p, void **); c++; diff --git a/libbb/pw_encrypt.c b/libbb/pw_encrypt.c index 4cdc2de76..fe06a8fe6 100644 --- a/libbb/pw_encrypt.c +++ b/libbb/pw_encrypt.c @@ -30,7 +30,7 @@ static int i64c(int i) int FAST_FUNC crypt_make_salt(char *p, int cnt /*, int x */) { /* was: x += ... */ - int x = getpid() + monotonic_us(); + unsigned x = getpid() + monotonic_us(); do { /* x = (x*1664525 + 1013904223) % 2^32 generator is lame * (low-order bit is not "random", etc...), -- cgit v1.2.3