From d840c5d139cfa50fbe4f6f67c178b0edf0c690c8 Mon Sep 17 00:00:00 2001 From: Ron Yorston Date: Sun, 19 Jul 2015 23:05:20 +0200 Subject: libbb: add a function to make a copy of a region of memory Introduce a library routine to package the idiom: p = xmalloc(b, n); memcpy(p, b, n); and use it where possible. The example in traceroute used xzalloc but it didn't need to. function old new delta xmemdup - 32 +32 last_main 834 826 -8 make_device 2321 2311 -10 common_traceroute_main 3698 3685 -13 readtoken1 3182 3168 -14 procps_scan 1222 1206 -16 forkchild 655 638 -17 ------------------------------------------------------------------------------ (add/remove: 1/0 grow/shrink: 0/6 up/down: 32/-78) Total: -46 bytes Signed-off-by: Ron Yorston Signed-off-by: Denys Vlasenko --- miscutils/last_fancy.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) (limited to 'miscutils') diff --git a/miscutils/last_fancy.c b/miscutils/last_fancy.c index 8194e31b5..e56e0ba85 100644 --- a/miscutils/last_fancy.c +++ b/miscutils/last_fancy.c @@ -233,7 +233,7 @@ int last_main(int argc UNUSED_PARAM, char **argv) break; } /* add_entry */ - llist_add_to(&zlist, memcpy(xmalloc(sizeof(ut)), &ut, sizeof(ut))); + llist_add_to(&zlist, xmemdup(&ut, sizeof(ut))); break; case USER_PROCESS: { int show; @@ -275,7 +275,7 @@ int last_main(int argc UNUSED_PARAM, char **argv) show_entry(&ut, state, boot_time); } /* add_entry */ - llist_add_to(&zlist, memcpy(xmalloc(sizeof(ut)), &ut, sizeof(ut))); + llist_add_to(&zlist, xmemdup(&ut, sizeof(ut))); break; } } -- cgit v1.2.3