From f625836e6059d307e951a60b60f1c9ed259ee983 Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Fri, 29 Sep 2017 18:02:01 +0200 Subject: udhcpc[6]: make log2 messages for chaddr field indented like the rest Signed-off-by: Denys Vlasenko --- networking/udhcp/dhcpc.c | 7 +++++++ 1 file changed, 7 insertions(+) (limited to 'networking/udhcp/dhcpc.c') diff --git a/networking/udhcp/dhcpc.c b/networking/udhcp/dhcpc.c index 2ae8bcc4d..4548d4ac7 100644 --- a/networking/udhcp/dhcpc.c +++ b/networking/udhcp/dhcpc.c @@ -1534,6 +1534,13 @@ int udhcpc_main(int argc UNUSED_PARAM, char **argv) */ if (send_renew(xid, server_addr, requested_ip) >= 0) { timeout >>= 1; +//TODO: the timeout to receive an answer for our renew should not be selected +//with "timeout = lease_seconds / 2; ...; timeout = timeout / 2": it is often huge. +//Waiting e.g. 4*3600 seconds for a reply does not make sense +//(if reply isn't coming, we keep an open socket for hours), +//it should be something like 10 seconds. +//Also, it's probably best to try sending renew in kernel mode a few (3-5) times +//and fall back to raw mode if it does not work. continue; } /* else: error sending. -- cgit v1.2.3