From 6937487be73cd4563b876413277a295a5fe2f32c Mon Sep 17 00:00:00 2001 From: James Byrne Date: Tue, 2 Jul 2019 11:35:03 +0200 Subject: libbb: reduce the overhead of single parameter bb_error_msg() calls Back in 2007, commit 0c97c9d43707 ("'simple' error message functions by Loic Grenie") introduced bb_simple_perror_msg() to allow for a lower overhead call to bb_perror_msg() when only a string was being printed with no parameters. This saves space for some CPU architectures because it avoids the overhead of a call to a variadic function. However there has never been a simple version of bb_error_msg(), and since 2007 many new calls to bb_perror_msg() have been added that only take a single parameter and so could have been using bb_simple_perror_message(). This changeset introduces 'simple' versions of bb_info_msg(), bb_error_msg(), bb_error_msg_and_die(), bb_herror_msg() and bb_herror_msg_and_die(), and replaces all calls that only take a single parameter, or use something like ("%s", arg), with calls to the corresponding 'simple' version. Since it is likely that single parameter calls to the variadic functions may be accidentally reintroduced in the future a new debugging config option WARN_SIMPLE_MSG has been introduced. This uses some macro magic which will cause any such calls to generate a warning, but this is turned off by default to avoid use of the unpleasant macros in normal circumstances. This is a large changeset due to the number of calls that have been replaced. The only files that contain changes other than simple substitution of function calls are libbb.h, libbb/herror_msg.c, libbb/verror_msg.c and libbb/xfuncs_printf.c. In miscutils/devfsd.c, networking/udhcp/common.h and util-linux/mdev.c additonal macros have been added for logging so that single parameter and multiple parameter logging variants exist. The amount of space saved varies considerably by architecture, and was found to be as follows (for 'defconfig' using GCC 7.4): Arm: -92 bytes MIPS: -52 bytes PPC: -1836 bytes x86_64: -938 bytes Note that for the MIPS architecture only an exception had to be made disabling the 'simple' calls for 'udhcp' (in networking/udhcp/common.h) because it made these files larger on MIPS. Signed-off-by: James Byrne Signed-off-by: Denys Vlasenko --- printutils/lpr.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-) (limited to 'printutils') diff --git a/printutils/lpr.c b/printutils/lpr.c index 7acb6c357..77d1a79a4 100644 --- a/printutils/lpr.c +++ b/printutils/lpr.c @@ -167,7 +167,7 @@ int lpqr_main(int argc UNUSED_PARAM, char *argv[]) // LPR ------------------------ // if (opts & LPR_V) - bb_error_msg("connected to server"); + bb_simple_error_msg("connected to server"); job = getpid() % 1000; hostname = safe_gethostname(); @@ -206,7 +206,7 @@ int lpqr_main(int argc UNUSED_PARAM, char *argv[]) * Standard lpr works around it by refusing to send such jobs: */ if (st.st_size == 0) { - bb_error_msg("nothing to print"); + bb_simple_error_msg("nothing to print"); continue; } @@ -246,7 +246,7 @@ int lpqr_main(int argc UNUSED_PARAM, char *argv[]) // send control file if (opts & LPR_V) - bb_error_msg("sending control file"); + bb_simple_error_msg("sending control file"); /* "Acknowledgement processing must occur as usual * after the command is sent." */ cflen = (unsigned)strlen(controlfile); @@ -262,12 +262,12 @@ int lpqr_main(int argc UNUSED_PARAM, char *argv[]) // send data file, with name "dfaXXX" if (opts & LPR_V) - bb_error_msg("sending data file"); + bb_simple_error_msg("sending data file"); fdprintf(fd, "\x3" "%"OFF_FMT"u d%s\n", st.st_size, remote_filename); get_response_or_say_and_die(fd, "sending data file"); if (bb_copyfd_size(dfd, fd, st.st_size) != st.st_size) { // We're screwed. We sent less bytes than we advertised. - bb_error_msg_and_die("local file changed size?!"); + bb_simple_error_msg_and_die("local file changed size?!"); } write(fd, "", 1); // send ACK get_response_or_say_and_die(fd, "sending data file"); @@ -283,7 +283,7 @@ int lpqr_main(int argc UNUSED_PARAM, char *argv[]) // say job accepted if (opts & LPR_V) - bb_error_msg("job accepted"); + bb_simple_error_msg("job accepted"); // next, please! job = (job + 1) % 1000; -- cgit v1.2.3