From 173aa78bcf68c2a036823bdee803b35820ddcd44 Mon Sep 17 00:00:00 2001 From: Denys Vlasenko Date: Fri, 28 Jun 2013 01:59:25 +0200 Subject: pstree: fix theoretically unsafe code In practice, p->comm is never long enough to trigger the bug, but still. Signed-off-by: Denys Vlasenko --- procps/pstree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) (limited to 'procps/pstree.c') diff --git a/procps/pstree.c b/procps/pstree.c index ea690a9c8..ed1a41289 100644 --- a/procps/pstree.c +++ b/procps/pstree.c @@ -349,7 +349,7 @@ static void dump_by_user(PROC *current, uid_t uid) static void handle_thread(const char *comm, pid_t pid, pid_t ppid, uid_t uid) { char threadname[COMM_DISP_LEN + 1]; - sprintf(threadname, "{%.*s}", (int)sizeof(threadname) - 1, comm); + sprintf(threadname, "{%.*s}", (int)sizeof(threadname) - 3, comm); add_proc(threadname, pid, ppid, uid/*, 1*/); } #endif -- cgit v1.2.3