From 825aead68b26a5857330972bd1c6adb9f78047ab Mon Sep 17 00:00:00 2001 From: Erik Andersen Date: Fri, 7 Apr 2000 06:00:07 +0000 Subject: Patch to make killall actually kill all PIDs with the specified name, rather then busylooping trying to kill the first one until it dies. Should be more efficient now, and will only send one signal to each specified process. -Erik --- procps/kill.c | 16 +++++++++++----- 1 file changed, 11 insertions(+), 5 deletions(-) (limited to 'procps') diff --git a/procps/kill.c b/procps/kill.c index 260f4a074..c6dc79f65 100644 --- a/procps/kill.c +++ b/procps/kill.c @@ -224,12 +224,18 @@ extern int kill_main(int argc, char **argv) else { /* Looks like they want to do a killall. Do that */ while (--argc >= 0) { - int pid; - - while((pid = findPidByName( *argv))) { - if (kill(pid, sig) != 0) - fatalError( "Could not kill pid '%d': %s\n", pid, strerror(errno)); + pid_t* pidList; + + pidList = findPidByName( *argv); + for(; pidList && pidList!=0; pidList++) { + if (kill(*pidList, sig) != 0) + fatalError( "Could not kill pid '%d': %s\n", *pidList, strerror(errno)); + else + errorMsg( "killed pid '%d'\n", *pidList); } + /* Note that we don't bother to free the memory + * allocated in findPidByName(). It will be freed + * upon exit, so we can save a byte or two */ argv++; } } -- cgit v1.2.3