Toybox with POSIX patches from E5ten https://git.carbslinux.org/forks/toybox/atom?h=0.5.0 2014-10-02T12:24:38+00:00 2014-10-02T12:24:38+00:00 Rob Landley rob@landley.net 2014-10-02T12:24:38+00:00 urn:sha1:2ccab0260f6812f78cc0bafdf2bb2a92942ee6f3 The Linux man page says I can use AT_SYMLINK_NOFOLLOW. It works in glibc, uclibc, and klibc, but musl returns -EINVAL any time you pass in that flag and the maintainer says that's not a bug and insists the man page and those other libraries all change to match musl's behavior. Toybox uses it to avoid scheduling unnecessary metadata writes for things we're about to delete (have to chmod unreadable directories so we can descend into them to delete their contents, the chmod happens before we descend so the disk I/O has plenty of time to be scheduled) because the extra writes wear out SSD faster. It's just an optimization and I don't really care if it works _well_ (the fchmodat call _also_ takes AT_SYMLINK_NOFOLLOW so that's covered), but musl's behavior uniquely makes the check always error and thus breaks normal "rm -r". Yes this workaround is checking #ifdef __MUSL__ which the library does not supply (because its code is perfect and will thus never need to be worked around). You can CFLAGS=-D__MUSL__ if you don't echo "#define __MUSL__" >> include/features.h when installing the library. 2014-09-28T18:11:20+00:00 Rob Landley rob@landley.net 2014-09-28T18:11:20+00:00 urn:sha1:562af2c0f2f4bd8420a26560f1816b6a81ac417e 2014-09-28T00:58:18+00:00 Rob Landley rob@landley.net 2014-09-28T00:58:18+00:00 urn:sha1:dc1af185e73410c5cad997c600678c212262a13c 2014-09-26T23:49:44+00:00 Rob Landley rob@landley.net 2014-09-26T23:49:44+00:00 urn:sha1:e0d8009d76b3a2451cb6c6ed2b241c7eff06ed60 Restricting usernames to the legacy posix character allowed set (for filenames, so the $HOME directory is creatable on VFAT and similar) means you can't have UTF-8 usernames. Linux allows any character but / and NUL in filenames. Since root is creating these entries, we assume root knows what it's doing. 2014-09-22T12:52:15+00:00 Rob Landley rob@landley.net 2014-09-22T12:52:15+00:00 urn:sha1:29d30be31123129deac142c6208faa7a1a98b2d0 dirtree->name is an array, not a pointer, so can't be zero. Remove the test. We dereference plen without checking it for null but calling dirtree_path(0, 0) is pilot error: only the _first_ call can have plen = 0. Add a comment. 2014-09-20T23:46:47+00:00 Rob Landley rob@landley.net 2014-09-20T23:46:47+00:00 urn:sha1:a1a83e671fdd91dcb763651ac86295c217574e6e I've been locally patching uClibc to not violate posix-2008 (you don't need to define a GNU macro to get a posix function), but uClibc is obsolete and moribund (development peaked in 2006, last bugfix release was over 2 years ago), and the largest remaining user (buildroot) doesn't bother to apply such a patch. Since even buildroot is slowly migrating to musl-libc, just do the portability tweak for what the last release of the old thing actually did. 2014-09-15T00:54:19+00:00 Rob Landley rob@landley.net 2014-09-15T00:54:19+00:00 urn:sha1:8a9907119bf22f2279470be40cf40027dc37018c 2014-09-14T17:29:44+00:00 Rob Landley rob@landley.net 2014-09-14T17:29:44+00:00 urn:sha1:360d57f843f5435a75270e54583430dcb8f62546 2014-09-07T19:42:51+00:00 Rob Landley rob@landley.net 2014-09-07T19:42:51+00:00 urn:sha1:25fe0e0bea85f1d851ce03a90c0f1bf41ab431f2 2014-09-06T18:24:58+00:00 Rob Landley rob@landley.net 2014-09-06T18:24:58+00:00 urn:sha1:980458f62748d273a006da3ddcd2b619d44598ce