forks/toybox/lib, branch 0.5.1Toybox with POSIX patches from E5ten
https://git.carbslinux.org/forks/toybox/atom?h=0.5.12014-11-19T22:55:12+00:00Fixups for the android/bionic build probes patch.2014-11-19T22:55:12+00:00Rob Landleyrob@landley.net2014-11-19T22:55:12+00:00urn:sha1:561478541dbeb92e2c82c2fda7b43461293938e9
The CFG_* symbols are always defined so if() can use them as compile-time
constants, so don't if defined() them.
Doing USE_BLAH() around variable definitions opens up the same potential for
config-dependent build breaks as #ifdefs do, just make the whole command
depend on the symbol for now, factor out the utmpx infrastructure later.
The PTY probe was always failing because it used NULL without #including
the header that defines it. Substitute 0 instead.
probe for getspnam(), forkpty(), utmpx, replace sethostname()2014-11-19T22:38:46+00:00Isaac Dunhamibid.ag@gmail.com2014-11-19T22:38:46+00:00urn:sha1:46ddf0e34b03f7711a9c80f7a70dc8cbf732f782
Android is missing all of these; we need to probe for some so we have
a config symbol to depend on.
sethostname() is easily replaced.
We got termios.h via pty.h; now it's not included in configure-step tools,
so we need termios.h to generate globals.
Remove unnecessary assignment spotted by Cynt Rynt.2014-11-11T21:08:25+00:00Rob Landleyrob@landley.net2014-11-11T21:08:25+00:00urn:sha1:6e087a3a6fb420efc5cb77e13818668212034225O_CLOEXEC was confusing the O_RDONLY test in loopfiles(), resulting in attempts to read from stdout instead of stdin for "-" or no arguments.2014-10-27T23:08:59+00:00Rob Landleyrob@landley.net2014-10-27T23:08:59+00:00urn:sha1:45b3882a1187f0e957efbc4fc5d797ba9603f545More static analysis fixes from Ashwini Sharma.2014-10-21T00:56:05+00:00Rob Landleyrob@landley.net2014-10-21T00:56:05+00:00urn:sha1:21f3c8db00f0d4a3f0989559847d2564f4c73a11Add TOYBOX_NORECURSE so xexec() won't make internal function calls.2014-10-21T00:52:29+00:00Rob Landleyrob@landley.net2014-10-21T00:52:29+00:00urn:sha1:977e48e1626b3e3f1f1f9b14f05ffc11e252455fFactor out printf-style escape parsing logic from echo.c.2014-10-18T22:14:12+00:00Rob Landleyrob@landley.net2014-10-18T22:14:12+00:00urn:sha1:5fcc71581abdf8839d10786d7ac437cc5b0bf4c5Use O_CLOEXEC instead of O_RDONLY to signal loopfiles_rw() to close filehandles.2014-10-14T19:16:34+00:00Rob Landleyrob@landley.net2014-10-14T19:16:34+00:00urn:sha1:784eb9c2d2cbd8ec49ff40dbaba17f4407f3b85aWorkaround for musl's faccessat bug (the rm -r "error: is a directory" thing).2014-10-02T12:24:38+00:00Rob Landleyrob@landley.net2014-10-02T12:24:38+00:00urn:sha1:2ccab0260f6812f78cc0bafdf2bb2a92942ee6f3
The Linux man page says I can use AT_SYMLINK_NOFOLLOW. It works in glibc,
uclibc, and klibc, but musl returns -EINVAL any time you pass in that flag
and the maintainer says that's not a bug and insists the man page and those
other libraries all change to match musl's behavior.
Toybox uses it to avoid scheduling unnecessary metadata writes for things we're
about to delete (have to chmod unreadable directories so we can descend into
them to delete their contents, the chmod happens before we descend so the
disk I/O has plenty of time to be scheduled) because the extra writes wear out
SSD faster. It's just an optimization and I don't really care if it works
_well_ (the fchmodat call _also_ takes AT_SYMLINK_NOFOLLOW so that's covered),
but musl's behavior uniquely makes the check always error and thus breaks normal
"rm -r".
Yes this workaround is checking #ifdef __MUSL__ which the library does not
supply (because its code is perfect and will thus never need to be worked
around). You can CFLAGS=-D__MUSL__ if you don't echo "#define __MUSL__" >>
include/features.h when installing the library.
Brown paper bag time: comma_scan() didn't work for anything but the last entry.2014-09-28T18:11:20+00:00Rob Landleyrob@landley.net2014-09-28T18:11:20+00:00urn:sha1:562af2c0f2f4bd8420a26560f1816b6a81ac417e