Toybox with POSIX patches from E5ten https://git.carbslinux.org/forks/toybox/atom?h=master 2019-06-08T02:53:50+00:00 2019-06-08T02:53:50+00:00 Tom Cherry tomcherry@google.com 2019-06-07T17:38:36+00:00 urn:sha1:61ef1dccec4e6bf1c56384ed1cd45f93dcb6bd4c These are Android specific, so not really helping the outside community, and are getting more and more Android dependencies to work correctly, so let's drop these from toybox and build them within Android. Change-Id: Ic6022f1f506e10868c61f55d64fa4e7c1b14eba2 2019-03-14T15:28:54+00:00 Elliott Hughes enh@google.com 2019-03-14T05:10:48+00:00 urn:sha1:4157ed0625ff7b166adac36d97988716651fde9e 2018-12-04T23:08:19+00:00 Elliott Hughes enh@google.com 2018-12-04T22:22:12+00:00 urn:sha1:141a075c0e192dc9910e777270114b1864270bfd Be consistent about upper versus lower case. (Upper seems to have the majority, so I went with that, though I'm happy to provide the opposite patch as long as we're consistent!) Be consistent about using \t. (Though saving a few bytes seems like it might be better done in the code that generates help.h rather than directly in the source, since tabs make careful ASCII art layout hard enough that we regularly have things misaligned.) Remove trailing periods (most of which seem to have been added by me). Always use the US "human readable" rather than my British "human-readable", and be more consistent about declaring whether we're showing multiples of 1000 or 1024. Just say "verbose" rather than adding a useless "mode" or "output". 2018-11-18T00:25:08+00:00 Rob Landley rob@landley.net 2018-11-18T00:25:08+00:00 urn:sha1:503e6362290d56bce0ed71f8164f24e25108bbbc 2018-10-04T17:53:59+00:00 Elliott Hughes enh@google.com 2018-09-27T23:34:49+00:00 urn:sha1:b33d37d6f735f008c15a4acf86a66e0e9a6dbef6 It's possible that we should just pull setprop back out of toybox to live with getprop in system/core/, but this lets us build the same toybox configuration for device and host in AOSP. (Longer term we'd like to use host bionic, but if we enable this we can start experimenting on the tobyox side before the bionic side is finished.) 2017-10-17T17:27:05+00:00 Tom Cherry tomcherry@google.com 2017-10-12T16:43:32+00:00 urn:sha1:11c385314ac0fac9694509639b03aa88a2ee5f6c Android now allows ro. properties to have arbitrary lengths. Two changes need to happen to support this: 1) The length check in setprop.c before attempting to set a property needs to be removed for ro. properties 2) __system_property_read_callback() must be used in place of __system_property_get() in getprop.c as only the former is capable of reading properties with size > 92 characters. Bug: 23102347 Bug: 34954705 Change-Id: Ib8565a3e6d987dd5e6a5fe790e804ecf8ad1e020 2017-06-01T06:03:13+00:00 Elliott Hughes enh@google.com 2017-05-31T18:01:11+00:00 urn:sha1:51a1e91d263ad14ffd4b57ff0c22d3ff02799ceb Bug: http://b/62114389 Test: setprop Change-Id: I165bcc01bb2422d991f746c5e6490cbdfb74472f 2017-05-25T00:56:58+00:00 Elliott Hughes enh@google.com 2017-05-24T00:35:49+00:00 urn:sha1:12f0744f340746b3a1c1accfdf993d6548f33e56 Everyone forgets that mmap returns MAP_FAILED rather than NULL on failure. Every use of mmap in toybox was either doing the wrong check, or no check at all (including the two I personally added). 2017-03-27T18:20:09+00:00 Elliott Hughes enh@google.com 2017-03-22T17:35:14+00:00 urn:sha1:7ec23e64af0f0bfd6e330c2cff467ae8524d16dd Fixes: toys/android/getprop.c:56:39: warning: incompatible pointer types passing 'void (void *, const char *, const char *)' to parameter of type 'void (*)(void *, const char *, const char *, uint32_t)' (aka 'void (*)(void *, const char *, const char *, unsigned int)') [-Wincompatible-pointer-types] __system_property_read_callback(pi, read_callback, NULL); ^~~~~~~~~~~~~ 2017-02-05T06:53:13+00:00 Rob Landley rob@landley.net 2017-02-05T06:53:13+00:00 urn:sha1:b4944cab5213e47be222f23dd60e86644e4f2186 (Broken out of a larger patch, fixed the other part a different way.)