diff options
author | Rob Landley <rob@landley.net> | 2014-12-15 03:34:55 -0600 |
---|---|---|
committer | Rob Landley <rob@landley.net> | 2014-12-15 03:34:55 -0600 |
commit | a1ea6bb8ea8143cc18fa00703e58819929501654 (patch) | |
tree | b188aa86e6016af475a8ce80bcdc2c0a780bb415 /toys/pending/ping.c | |
parent | 807a50d89976e2de081d487a54e8e109d49f0a6d (diff) | |
download | toybox-a1ea6bb8ea8143cc18fa00703e58819929501654.tar.gz |
Fix yet another sed bug.
The s/// command would copy the \ of substitutions before deciding what to
do with them (generally overwriting the \ with the new data). When the
substitution was A) at the very end of the new string, B) resolved to nothing,
it could leave a trailing \ that didn't belong there and didn't get overwritten
because the "copy trailing data" part that copies the original string's null
terminator already happened before the \ overwrote it.
The ghostwheel() function restarts regexes after embedded NUL bytes, but
if the string it's passed is _longer_ than the length it's told then it
gets confused (and it means we're off the end of our allocation so segfaults
are likely).
Fix: test for \ first and move the "copy byte" logic into an else case.
Diffstat (limited to 'toys/pending/ping.c')
0 files changed, 0 insertions, 0 deletions