aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2018-03-14Fix last uninitialized warning.Elliott Hughes
clang is fine with the noreturn nature of error_exit, but only if we don't `if (false)` it out for non-debug builds. lib/args.c:304:18: error: variable 'temp' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized] } else if (CFG_TOYBOX_FLOAT && new->type == '.') { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ external/toybox/generated/config.h:11:26: note: expanded from macro 'CFG_TOYBOX_FLOAT' ^ external/toybox/lib/args.c:308:19: note: uninitialized use occurs here options = --temp; ^~~~ external/toybox/lib/args.c:304:14: note: remove the 'if' if its condition is always true } else if (CFG_TOYBOX_FLOAT && new->type == '.') { ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~ external/toybox/lib/args.c:255:15: note: initialize the variable 'temp' to silence this warning char *temp; ^ = NULL
2018-03-13Add beep feature to watchMinghui Liu
2018-03-12bc cleanup: a few obvious inlines.Rob Landley
Inline #define bcg TT (from generated/globals.h) Inline BC_FLAG with FLAG_ values from generated/flags.h. Replace BC_MAX() and BC_MIN() with maxof() and minof() from Inline BC_INVALID_IDX (it's used twice and doesn't need a typecast). Inline bc_func_insertParam() and bc_func_insertAuto() (each is used once).
2018-03-12bc cleanup: move for(int i;) declarations to int i; for(i;).Rob Landley
Coding style: declarations go at the start of blocks.
2018-03-12Add xxd -o.Elliott Hughes
2018-03-12Fix bug in names_to_pid.Elliott Hughes
Found by the compiler, not me: lib/lib.c:1053:30: warning: 'st2.st_dev' may be used uninitialized in this function [-Wmaybe-uninitialized] if (st1.st_dev != st2.st_dev || st1.st_ino != st2.st_ino) continue; ~~~^~~~~~~
2018-03-11Add bc to pendingGavin Howard
2018-03-10Split "comma separated values" parsing from mntent.h plumbing.Rob Landley
2018-03-10Add a way for commands to distinguish "ps -ax" from "ps ax".Rob Landley
2018-03-10Add getra and setra to blockdevNg Zhi An
Bug: 74390492
2018-03-10Record the news.html update for last release.Rob Landley
2018-02-24Update version string to 0.7.6.0.7.6Rob Landley
2018-02-22Bugfix, facility values are <<3 in the headers.Rob Landley
2018-02-18Work around a musl-libc bug that has facilitynames/prioritynames in headersRob Landley
but then the link fails.
2018-02-17Add RFC link to the examples.Rob Landley
2018-02-10Fix ps -T again, but this time read files from tid directory, not pid.Rob Landley
(Otherwise updating pid to parents makes threads read thread parent data.)
2018-02-10Rename struct strawberry -> struct ofields, and carveup -> procpid.Rob Landley
The first contains display fields selectable by the -o argument, the second contains the /proc/$PID data for one process.
2018-02-09Fix the pidof comm and cmdline tests.Elliott Hughes
If we have a 15-byte name, we don't know whether comm actually matches or is a truncated form of a longer name that has a common prefix. For example, with "this-is-a-very-long-name-that-is-too-long", we shouldn't match "this-is-a-very-" (but the old code would). The cmdline code was also broken on Android because it used basename(3) rather than getbasename. This doesn't affect glibc because there's a workaround in portability.h to ensure that we get the non-POSIX basename(3) with glibc but then a non-glibc section that ensures everyone else gets POSIX basename(3). That should probably be removed (and maybe `basename` poisoned) to prevent similar mistakes in future. Bug: http://b/73123244
2018-02-09Andreas Gampe suggested a different fix.Rob Landley
(Bionic _does_ do the malloc(0)!=0 thing, the problem is pedantic access checking, not null dereference. So test count instead.)
2018-02-08Thinko pointed out by Andreas Gampe (causing segfaults in top, oops).Rob Landley
2018-02-04People keep running ./configure, so have it do a defconfig for them.Rob Landley
2018-02-04Add crc32.Rob Landley
In cksum, make -H pad with leading zeroes to 8 chars, don't output len with -N, and don't output filename with zero arguments.
2018-01-31Ahem, I _said_ basic ping support.Rob Landley
2018-01-30Basic ping support.Rob Landley
Requires echo 0 $((1<<30)) > /proc/sys/net/ipv4/ping_group_range (as root)
2018-01-24Revert the ps -T thing until I understand what Elliott wants.Rob Landley
2018-01-23Fix hang in losetup test.Elliott Hughes
Switch the printf over to %s because the input is actually hex (so %d is wrong), but without the leading "0x" that %x would require. For some reason the NODE assignment wasn't providing any input to awk (hence the hang), and awk wasn't looking for the correct field anyway. The tests still fail for me: losetup: /dev/block/loop0: No such device or address losetup: /dev/block/loop0: No such device or address losetup: file: No such file or directory losetup: needs 1 arg (see "losetup --help") But at least now they allow the other tests to continue!
2018-01-21Fix variables in help.txtReverend Homer
2018-01-21gzip cleanup: fix test_gzip, unify do_gzip/do_gunzip, inline gzerror_msg().Rob Landley
2018-01-20Fix gunzip to past test_gunzip.Rob Landley
2018-01-15Fix "ps -T 1234" to show thread belonging to that PID.Rob Landley
2018-01-15Merge shared_main() back into ps_main() and top_main(), add comments.Rob Landley
2018-01-15Add more comments to ps.Rob Landley
2018-01-14Switch xgettty() -> tty_fd() (returning -1 instead of erroring out if none).Rob Landley
2018-01-10Move make help text out of Makefile.Rob Landley
2018-01-09Add the gzip/gunzip/zcat tests I wrote for toolbox gzip/gunzip/zcat.Elliott Hughes
Bringing the zlib-based gzip/gunzip/zcat over to toybox is a problem for another day, but at least the tests are easy... (These tests pass with TEST_HOST and on the toolbox versions, but the toybox toys are in pending and very broken.)
2018-01-06Move millitime() into lib.c.Rob Landley
2018-01-03Cleanup pass on gzip.c.Rob Landley
2018-01-01Promote logger, and fluff up help text a bit.Rob Landley
2018-01-01Cleanup logger.c, and move the facilitynames/prioritynames SYSLOG_NAMESRob Landley
stuff syslog.h does into lib.c and portability.h
2018-01-01xphung on github said: "config2help currently doesn't work on OS X, itRob Landley
terminates parsing of Config.in at first blank line. This is because getdelim() in portability.c returns -1 whenever the line comprises only a single linefeed character. Fixing this was a trivial change to two lines (see below), and config2help now works on OS X but I haven't regression tested this on any other commands which rely on getdelim()"
2017-12-29Promote iconv.Rob Landley
2017-12-29Cleanup iconv.Rob Landley
Implement -c, fix endless loop when illegal char happens with !outleft (don't need to check errno, just in == toybuf), refill buffer each time (less efficient handling of illegal chars but never have to worry about how long constitutes a valid sequence in unknown encoding). Fix input longer than 2k (memmove() has src/dest switched, second time through loop in starts at offset inleft...) Made it start at beginning every time. Switch iconv_open() error msg to show to/from and errno (rather than hardwired english text).
2017-12-27Promote setfattrRob Landley
2017-12-27Minor cleanup on setfattr.cRob Landley
2017-12-26Add xxd -i (and xxd -ri).Elliott Hughes
The original xxd doesn't support -r with -i. The original also outputs "unsigned char name[] = { ... };" for input other than stdin, but that actually makes it less useful --- many languages support array initializers, but far fewer support that exact declaration syntax. Also fix the -c range checking and defaulting: ><= in the argument string only works for floating point arguments. Bug: http://b/64711851
2017-12-26Fix xargs -0 with -n.Elliott Hughes
Also make -0 and -E mutually exclusive (rather than just ignore -E with -0). Bug: https://github.com/landley/toybox/issues/78
2017-12-24Add fmt.Elliott Hughes
A very simple implementation of fmt, good enough for my daily use of !!fmt in vi to reflow checkin comments like this.
2017-12-22Redo namestopid to handle more cases.Rob Landley
2017-12-19Fix make bloatcheck dependencies (pointed out by Patrick Oppenlander).Rob Landley
2017-12-19killall should kill scripts too.Elliott Hughes
Found running LTP file system tests on Android. Bug: http://b/70627145