aboutsummaryrefslogtreecommitdiff
AgeCommit message (Collapse)Author
2015-03-01Fix several printf_format warnings.Rob Landley
2015-03-01Only switch on printf format warnings for error_exit() and friends when ↵Rob Landley
TOYBOX_DEBUG enabled. One again gcc manages to be incompetent about producing warnings. For example, in bzcat we error_exit() with a message that's an error code fed into an array of string constants, and apparently dereferencing an array of string literals doesn't give you a string literal according to -Wformat-security. Not breaking the code to humor the compiler here, the compiler is wrong.
2015-03-01let the compiler check format stringsElliott Hughes
i'll be AFK for a week, so here's the patch i've been using this evening to find other format string mistakes. BSD uses __printflike and takes two arguments instead of hard-coding (1,2), but i figured that as long as you don't need the generality you'd prefer not to have it. and it's easy enough to retrofit if we ever do have a formatting function that takes other arguments.
2015-03-01fix format problems in tar.cElliott Hughes
%o is unsigned, but off_t is signed. * takes an int. an error_msg call was missing an argument. only one of these is an actual error, but i'd like to fix the others too so that we (toybox, but if not, then Android) can turn on format string warnings to prevent future bugs like the stat.c LP32 ones.
2015-03-01Patches from Elliott Hughes to fix various printf() format strings.Rob Landley
(Don't specify the space flag when it's the default behavior. The ifconfig stuff was actual bugs.)
2015-03-01Patches from Elliott Hughes to add missing arguments to error_exit() calls.Rob Landley
2015-03-01remove accidental space in format stringElliott Hughes
the ' ' flag makes no sense for %c.
2015-03-01fix copy/paste-o in useradd.testElliott Hughes
2015-02-27Cleanup pass on ps.Rob Landley
2015-02-270.5.2 release notes.Rob Landley
2015-02-28Minor toysh cleanup: remove another unnecessary option.Rob Landley
2015-02-28BSD sed uses -E instead of -r to enable ERE.Isabella Bosia
GNU sed silently supports -E as an alias for -r too.
2015-02-28Add LDFLAGS and STRIP=no support.Rob Landley
2015-02-28Add "make change" output to .hgignoreRob Landley
2015-02-26More 'splaining.Rob Landley
2015-02-25Added tag 0.5.2 for changeset 8ce8c5365f8bRob Landley
2015-02-25stat -f didn't work on 32 bit systems because type sizes wrong (fix from ↵0.5.2Rob Landley
Elliott Hughes).
2015-02-18Patch from Isaac Dunham to add -r, fixed up so it doesn't try to include two ↵Rob Landley
flag contexts simultaneously.
2015-02-18Separate 'userdel' from testing syntax.Yeongdeok Suh
When I test toybox with toybox/tests/*.test scripts, I got many false FAILs from it. So, I tried to fix useradd.test file.
2015-02-15Add --remove-destination longopt for -F because the host version doesn't ↵Rob Landley
have a shortopt for it.
2015-02-15Only discard optargs in toy_exec() after finding the command to run ↵Rob Landley
(otherwise the fallback exevp() segfaults).
2015-02-14Make egrep and fgrep build standalone.Rob Landley
2015-02-14Fix --help for single.sh builds.Rob Landley
2015-02-14Split out unix2dos so scripts/single.sh and "make change" can build it ↵Rob Landley
standalone.
2015-02-14Move guts of "make change" to scripts/change.sh, don't try to build sh or ↵Rob Landley
help standalone. sh builtin commands need multiplexer, help describes other enabled commands.
2015-02-12Fix bug introduced by last commit (print template instead of toybuf).Rob Landley
Also, xstrdup() the unmodified template because changing the environment string could make the changed version show up in "ps".
2015-02-11Only apply mktemp directory to targets that aren't already paths.Rob Landley
2015-02-10Fix longopts (pointed out by Hyejin Kim).Rob Landley
2015-02-09One more cleanup pass on hwclock factoring out common code.Rob Landley
2015-02-09Inline rtc_open() and get_rtc_seconds(), perform resulting cleanups.Rob Landley
2015-02-09Cleanup/refactoring pass on hwclock.Rob Landley
Inline open_wall_clock_rtc() into rtc_open(), factor out xtzset(), inline set_sysclock_from_hwclock(), set_hwclock_from_sysclock(), and set_sysclock_timezone(). /etc/adjtime is short enough we don't need to bother with a break. The final "else" case in main() should always trigger because >0 in optstr says "at most zero arguments", so the || at the end is always true, so take the test off.
2015-02-08Promote chcon to "other".Rob Landley
2015-02-08Cleanup pass on chcon.Rob Landley
2015-02-08Rewrite of a patch from Elliott Hughes to implement touch -h and switch API ↵Rob Landley
to utimensat() which offers nanosecond granularity and UTIME_OMIT/UTIME_NOW.
2015-02-08For some reason, ifconfig was explicitly excluding "ifconfig lo:0 127.0.0.2" ↵Rob Landley
style alias address assignments. No idea why.
2015-02-07netcfg is being removed, but shows up in the toybox roadmap.Elliott Hughes
2015-02-07Shameless meddling.Rob Landley
2015-02-07Use $TMPDIR if set (necessary on Android, where there is no /tmp).Elliot Hughes
Include full template in error messages. Don't report success on failure with -q. Avoid unnecessary allocation. Fix "xxxxxx" versus "XXXXXX" confusion.
2015-02-07Build standalone commands where "depends on" config entries need to be ↵Rob Landley
switched on.
2015-02-07Clean up the output of "make change".Rob Landley
2015-02-07Remove xexec_optargs().Rob Landley
2015-02-07Cleanup pass on env, removing exec_optargs().Rob Landley
2015-02-07Make toy_exec() check if argc is in optargs and deal with it there so we ↵Rob Landley
don't need a separate xexec_optargs().
2015-02-07Merge unshare and nsenter (promoting and cleaning up nsenter).Rob Landley
Needs more testing, don't have a test environment set up for this yet...
2015-02-06In rm, init using to AT_REMOVEDIR in the dir case earlier.Rob Landley
(If you had a chmod 000 directory and did rm -r on it without -f, after the prompt it would complain it was a directory.)
2015-02-06Alright, the Android guys agree with the musl guys: ↵Rob Landley
faccessat(AT_SYMLINK_NOFOLLOW) is not supported.
2015-01-25Commit 1061 said "this gets expand off my to-review list". Remove it from ↵Rob Landley
the list.
2015-01-25Cleanup mountpoint and remove it from the pending README.Rob Landley
2015-01-22bootchartd: Removing wrong free call to non-malloc'ed string.Luis Felipe Strano Moraes
2015-01-22Fix sed s//\[newline]/ line continuations.Rob Landley
The problem was that readline() was returning a newline at the end of each string, which wasn't getting stripped in the parser and thus \ wasn't at the end of a line for -f, it was escaping a literal newline, so the continuation logic didn't trigger. Remove some redundant null checks while we're at it, and don't bother terminating a string we don't return (yes we leak memory in an error path, but it's about to error_exit() anyway).