Age | Commit message (Collapse) | Author |
|
Simplify the config micromanagement tangle to just a single "interactive"
option. Fix an unused variable and wrong variable type.
|
|
and posix-2008 doesn't say if fflush() covers ferror() (or can return success when the stream's error state is set), so call both.
|
|
partition table. This is often used on embedded systems booting from SD/USB devices that need to resize partitions on first boot.
|
|
can be used in place of locally defined strtorange() function.
|
|
Since the starting letters are greater than those for 'id' or 'groups',
we cn just check if the first letter is greater than 'i'.
|
|
minor cleanups I had in my tree already.
|
|
|
|
|
|
doesn't show it. Instead make the "not root" failure case always show help text.
|
|
variable can never actually be used uninitialized but gcc's warning generator can't tell and fails spamwards" warning.
|
|
broken build environments that provide different libraries for --static and dynamic builds.
|
|
as EOF.
|
|
e.g. Wireless adapter, Bluetooth devices...
|
|
|
|
Renamed the function, missed a user...
|
|
|
|
|
|
|
|
|
|
where a SIGCHLD could get lost.
|
|
toys.signalfd if set.
|
|
rename set_sane_term() to reset_term() and have it take the fd it works on as an argument, some whitespace and help text tweaks.
|
|
|
|
|
|
|
|
The parsing logic kept checking for other options beyond __pad__ option, without
checking if it was __end__ option after that or not.
|
|
-i is how standard lspci handles changing the PCI ID database.
lspci -n should be a no-op when text is disabled.
|
|
Might have broken something, don't actually have a test case for bootchartd yet.
|
|
start of code.html, so move it to design.html.
|
|
|
|
|
|
If we're building a standalone version, it might as well have all the bells and whistles enabled.
|
|
|
|
On my machine, for a 2.2 GB file of random bytes, the timings with
warm cache are:
toybox before: 11.4 seconds
toybox after: 8.3 seconds
GNU md5sum: 3.9 seconds
openssl dgst -md5: 3.5 seconds
This is clearly better than before (3x openssl), but still slow (2x openssl).
I suspect there is more low-hanging fruit to be had by eliminating the
memcpy in hash_update (maybe not too much - hash_update accounts for
about 4% of total runtime versus 92% for md5_transform according to
perf - but this would also help sha1sum).
make bloatcheck on x86_64 gcc 4.8.2 -Os:
name old new delta
-----------------------------------------------------------------------
md5rot 0 64 64
md5_transform 365 223 -142
-----------------------------------------------------------------------
-78 total
Rationale for the changes:
Move definition of 'rol' up so it can be used in md5_transform. This
is purely cosmetic; it expands to exactly the same code.
Put rotation counts in a lookup table instead of calculating them on
the fly. This is mostly a wash size-wise, +5 bytes total, but
worthwhile for readability and speed.
Instead of accessing the state array using a rotating index (the
variable formerly known as 'a'), access the state with constant
offsets and rotate the contents of the array instead. This is the big
win - it eliminates all the crazy memory addressing math inside the
loop.
|
|
|
|
|
|
Not heavily tested yet but should be finished at the design level.
|
|
Remove unnecessary typecasting of things that are already char * to char *,
and multiplying by sizeof(char *) which is 1. Rename do_process() do_flag_a()
since that's the only caller. Move read_key_values() down past trim_spaces()
and read_config_file() so it's next to its only two users. Replace some
euphemisms for 0 with 0.
replace_char() really sounds like something libc should already have one of,
but I'm blanking on it if so. (It doesn't need a temporary variable when the
argument variable is already a copy so changing it won't affect the caller.)
|
|
|
|
|
|
so strncmp(dest, "string", sizeof("string")) is just strcpy.
|
|
loop, don't bother to stat an empty file to report when an empty log was created (just report current time).
|
|
identify the culprit).
|
|
du use it, move it from lib/pending.c to lib.c.
|
|
or float for FLOAT arguments. (I.E. whether double fits in a long's memory.) Check in a way that the macros not being defined just gives us the shorter one.
|
|
toy_init() doesn't zero the rest of the struct.
|
|
free can cause a crash, if the buffer passed by user of function is not malloc'ed one.
names_to_pid() is one usecase example here.
|
|
This is the modified and better version from the last one I sent.
It is having the both the mains (lsattr_main() and chattr_main() )
in single file.
Also removed the dependency of additional file in lib, as common code is in the
same .c file.
|
|
Note that directory timestamps are still sometimes wrong because creating
things in a directory can update the timestamp. Also, cp -r has logic to
ensure we can write to a directory that doesn't have write permission,
cpio does not. This is fixable, but not what existing cpio does.
|
|
|