| Age | Commit message (Collapse) | Author |
|---|
|
Optionally, accept and acknowledge OACK from server after sending original RRQ, if the server implements RFC2347 and responds first with an OACK before sending DATA packets.
|
|
|
|
|
|
|
|
|
|
|
|
Note: ubuntu will show -m through a file, this treat that as error.
|
|
If you ever do have a command name beginning with a -, eval won't run it by
default, because even though it takes no arguments it tries to parse them
anyway, so it complains it's an unrecognized argument. Solution: -- as first
argument (which is parsed and stops argument parsing).
|
|
|
|
ln -f does the rm and retry if the first attempt fails for any reason.
So if you run the readlink test with an ubuntu host $PATH, it fails, but
it works with a toybox host path.
|
|
toys/other/vmstat.c:98:12: error: logical not is only
applied to the left hand side of this bitwise operator
[-Werror,-Wlogical-not-parentheses]
if ((!toys.optflags&FLAG_n) && isatty(1)) terminal_size(0, &rows);
^ ~
|
|
|
|
(This way "make test_sed" isn't in the same namespace as "make test_scankey".)
|
|
|
|
care.)
|
|
remove redundant CLOEXEC (xsocket does it) and CFG_NETCAT_LISTEN test
(we're not doing FORCE_FLAGS so FLAG_L and FLAG_l become zero), remove
comments about vfork triggering compiler/libc bugs (XVFORK handles it).
|
|
|
|
print the first header line.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
48 cores is too much to fit in toybuf.
|
|
|
|
|
|
wouldn't let him assign a negative default value, so I fixed it.
|
|
|
|
to touch it in the meantime, so no point having it in pending.
|
|
clang is fine with the noreturn nature of error_exit, but only if we don't
`if (false)` it out for non-debug builds.
lib/args.c:304:18: error: variable 'temp' is used uninitialized whenever 'if' condition is false [-Werror,-Wsometimes-uninitialized]
} else if (CFG_TOYBOX_FLOAT && new->type == '.') {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
external/toybox/generated/config.h:11:26: note: expanded from macro 'CFG_TOYBOX_FLOAT'
^
external/toybox/lib/args.c:308:19: note: uninitialized use occurs here
options = --temp;
^~~~
external/toybox/lib/args.c:304:14: note: remove the 'if' if its condition is always true
} else if (CFG_TOYBOX_FLOAT && new->type == '.') {
^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
external/toybox/lib/args.c:255:15: note: initialize the variable 'temp' to silence this warning
char *temp;
^
= NULL
|
|
|
|
Inline #define bcg TT (from generated/globals.h)
Inline BC_FLAG with FLAG_ values from generated/flags.h.
Replace BC_MAX() and BC_MIN() with maxof() and minof() from
Inline BC_INVALID_IDX (it's used twice and doesn't need a typecast).
Inline bc_func_insertParam() and bc_func_insertAuto() (each is used once).
|
|
Coding style: declarations go at the start of blocks.
|
|
|
|
Found by the compiler, not me:
lib/lib.c:1053:30: warning: 'st2.st_dev' may be used uninitialized in this function [-Wmaybe-uninitialized]
if (st1.st_dev != st2.st_dev || st1.st_ino != st2.st_ino) continue;
~~~^~~~~~~
|
|
|
|
|
|
|
|
Bug: 74390492
|
|
|
|
|
|
|
|
but then the link fails.
|
|
|
|
(Otherwise updating pid to parents makes threads read thread parent data.)
|
|
The first contains display fields selectable by the -o argument,
the second contains the /proc/$PID data for one process.
|
|
If we have a 15-byte name, we don't know whether comm actually matches
or is a truncated form of a longer name that has a common prefix.
For example, with "this-is-a-very-long-name-that-is-too-long", we shouldn't
match "this-is-a-very-" (but the old code would).
The cmdline code was also broken on Android because it used basename(3)
rather than getbasename. This doesn't affect glibc because there's a
workaround in portability.h to ensure that we get the non-POSIX basename(3)
with glibc but then a non-glibc section that ensures everyone else gets
POSIX basename(3). That should probably be removed (and maybe `basename`
poisoned) to prevent similar mistakes in future.
Bug: http://b/73123244
|
|
(Bionic _does_ do the malloc(0)!=0 thing, the problem is pedantic access
checking, not null dereference. So test count instead.)
|
|
|
