aboutsummaryrefslogtreecommitdiff
path: root/toys/pending
AgeCommit message (Collapse)Author
2013-06-02Stat cleanup.Rob Landley
lib: rename format_mode() to mode_to_string() (echoing string_to_mode), make it take a normal char * argument. stat: collapse big switch/case statements that only have one line each into if/else staircase (much fewer lines of code). Remove return type (other stat implementations print ? for unknown escapes, so do that here). Inline do_stat() and do_statfs(). Set default string in normal local variable "format". Remove unnecessary struct d. Restructure stat logic to "if (flagf && !statfs()) else if (!flagf && !stat()) else perror_msg();" Teach %N to add -> symlink. Judicious use of putchar() instead of xputc to let FILE * do its job collating output.
2013-06-01Stat cleanup.Rob Landley
Put global stat info in a union so we don't have to malloc it and thus don't need an explicit size tracked in main(). Make date_stat_format() take a timespec and take advantage of stat having an embedded timespec (nanosecond printing), typecast the long long prints for XYZ because on some 32 bit platforms it's an int.
2013-05-28Stat cleanup.Rob Landley
From the mailing list: Ok, first thing: clean up the help text. I realize what's there is copied verbatim from the man page, but that man page sucks. ("modification time" vs "change time"?) Took a bit of finagling to fit it in 80x24, but just made it. GLOBALS() indent was still tab, change to two spaces. And I tend to put a blank line between options lib/args.c automatically fills out and normal globals. We never do anything with date_stat_format() but immediately print it, might as well make the function do it. The types[] array in do_stat() is a rough edge. Hmmm... there's no else case that sets the type in case it was unknown (such as 0). In theory, this never happens. In practice it means I can cheat slightly, given this observation: $ find linux -name stat.h | xargs grep 'S_IF[A-Z]*[ \t]' linux/include/uapi/linux/stat.h:#define S_IFMT 00170000 linux/include/uapi/linux/stat.h:#define S_IFSOCK 0140000 linux/include/uapi/linux/stat.h:#define S_IFLNK 0120000 linux/include/uapi/linux/stat.h:#define S_IFREG 0100000 linux/include/uapi/linux/stat.h:#define S_IFBLK 0060000 linux/include/uapi/linux/stat.h:#define S_IFDIR 0040000 linux/include/uapi/linux/stat.h:#define S_IFCHR 0020000 linux/include/uapi/linux/stat.h:#define S_IFIFO 0010000 I.E. the only place the I_IFBLAH constants occur a stat.h header in current linux code is in the generic stuff, it doesn't vary per target. (The access permission bits are actually subtly standardized in posix due to the command line arguments to chmod, although I'm sure cygwin finds a way to break. But the type fields, not so much. But linux has to be binary compatible with itself foreverish, and that's all I really care about.) So, we have ALMOST have this going by twos, except there's no 8 and there is a 1. so let's make the 1 the default, feed a blank string into the 8... No, duh: octal. So it's actually 2, 4, 6, 8, 10, 12. So make the loop look like: filetype = statf->st_mode & S_IFMT; TT.ftname = types; for (i = 1; filetype != (i*8192) && i < 7; i++) TT.ftname += strlen(TT.ftname)+1; Yes that's linux-specific, and I think I'm ok with that. Printing all zeroes and pretending that's nanosecond resolution... either support it or don't. Let's see, supporting it is stat->st_atim.tv_nsec and similar... no mention of nanoseconds in strftime() (et tu, posix2008?) so pass it as a second argument and append it by hand... (Need to test that against musl...) When we hit an unknown type in print_it() we print the literal character, which is right for %% but what about an unknown option? $ stat -c %q / ? Eh, I guess that's a "don't care". It didn't die with an error, that's the important thing. I have a horrible idea for compressing the switch/case blocks, but should probably check this in and get some sleep for right now...
2013-05-26stat: Separate stat and statfsFelix Janda
2013-05-25stat: Add support for stat'ing multiple filesFelix Janda
2013-05-21More ifconfig cleanup, inlining show_ip_addr(), hex_to_binary(), and ↵Rob Landley
set_hw_address().
2013-05-20Next round of ifconfig cleanup, to be described on mailing list.Rob Landley
2013-05-19Yet more ifconfig cleanup. (As described on the mailing list [CLEANUP] thread.)Rob Landley
2013-05-12Ifconfig cleanup to option parsing.Rob Landley
2013-05-07Some work I did over the weekend on nbd_client, not sure where I left off...Rob Landley
2013-04-26Fix find -mtimeFelix Janda
2013-04-22stat: Remove unimplemented options and clean up help textFelix Janda
2013-04-22Add library function for the file permission formatting in ls and statFelix Janda
2013-04-26Add posix headers to toynet.h, move xioctl() to lib.c, introduce lib/net.c ↵Rob Landley
and move xsocket() to it.
2013-04-25And another round of ifconfig cleanup.Rob Landley
2013-04-24Yet more drive-by cleanup of ifconfig.Rob Landley
2013-04-21More find cleanupFelix Janda
2013-04-20More find cleanupFelix Janda
2013-04-20stat cleanupFelix Janda
2013-04-19stat: Reindent from 4 to 2 spacesFelix Janda
2013-04-20More ifconfig cleanup.Rob Landley
2013-04-20ifconfig cleanup (Reorder functions to eliminate need for prototypes, put ↵Rob Landley
main at end).
2013-04-18find: Improve operator processingFelix Janda
2013-04-19Another round of ifconfig cleanup.Rob Landley
2013-04-16More ifconfig cleanup.Rob Landley
2013-04-16Fix the help commit I screwed up, and replace leading tabs with spaces.Rob Landley
2013-04-16More ifconfig cleanup.Rob Landley
2013-04-16Isaac Dunham's help string cleanup.Rob Landley
2013-04-14ifconfig uses __caddr_t in one location; this is not guaranteed to work ↵Isaac Dunham
everywhere. It does not compile OOB on musl, so I changed it to the portable equivalent, char *. This compiles on musl, and should compile anywhere.
2013-04-12Convert tabs to spaces.Rob Landley
2013-04-12xzcat: more cleanup and some shrinking.Isaac Dunham
-drop __always_inline (c. 1.5k of binary size), -remove the xz_dec_bcj_end and memzero macros (memeq is left because of negative returns), -disable XZ_DEC_SINGLE and XZ_DEC_PREALLOC, since we aren't using them. (160 bytes) -Merge xz_dec_lzma2_end into xz_dec_end -Move xz_crc32 to where it's defined. (That does not seem to be duplicated elsewhere in toybox.)
2013-04-11More ifconfig cleanup.Rob Landley
2013-04-11More xzcat cleanup.Rob Landley
2013-04-11More of same.Isaac Dunham
Actually, it's not quite the same: -use crc_init(xz_crc32_table,1) -- I guessed on this one based on a match between magic constants, then tested it. First try was wrong, but this works. (This is the sole difference in terms of actual _code_, as opposed to cleaning up defines and the like--here, it adds 48 bytes to final size if xzcat is the only toy, but drops 32 bytes if bzcat is also enabled...) -Move some crc64 code to where the comments are. This puts them near the area where they're used. -Remove some relics of separate files (we had half a dozen "this file is in the public domain" notices, a duplicate include, and used extern declarations for functions in the samefile)
2013-04-10More cleanup on find.Rob Landley
2013-04-10Redo find's indenting from tabs to two spaces.Rob Landley
2013-04-10Partial cleanup of findFelix Janda
- Remove unnecessary headers - dump_node is not used anywhere - exec_buf is unused - Replace SUCCESS with 1 and simplify code accordingly - a==0 -> !a - Simplify an incremation pattern using pre-increments - Add static keyword to functions - Make error messages print to stderr
2013-04-10Some xzcat cleanup by Isaac Dunham.Rob Landley
2013-04-05More ifconfig cleanups, mostly removing unused code.Rob Landley
2013-04-04Drive-by cleanup on ifconfig.Rob Landley
2013-04-04An ifconfig bugfix from the original submitter.Rob Landley
2013-04-02Kyungwan Han submitted ifconfig.Rob Landley
2013-04-02Clean uudecode up the rest of the way, move pending->posix and default y.Rob Landley
2013-03-28More uudecode cleanup.Rob Landley
2013-03-28More uudecode cleanup.Rob Landley
2013-03-27Incremental cleanup of uudecode.Rob Landley
2013-03-27Fix the USE() macro around NEWTOY, tweak help text, remove unnecessary ↵Rob Landley
wrapper, tweak whitespace and curly brackets.
2013-03-26Add help text for pending test command. (No actual implementation yet.)Rob Landley
2013-03-26Finish uuencode cleanup, default y, move it from pending to posix.Rob Landley
2013-03-24First round of uuencode cleanup: generate table, tweak help text, remove ↵Rob Landley
unnecessary output buffers, simplify base64 functions..