| Age | Commit message (Collapse) | Author |
|---|
|
|
|
Working my way through the to-review list that predates the "pending"
directory. This gets expand off my to-review list. (Proof that "need to
review" doesn't mean it's in bad shape, this command was fine. Changed
capitalization in the help text because I'm trying to have "user supplies
this value" be all caps, switched a read() to readall() although I'm not
sure modern kernels actually allow -EINTR to generate zero length reads
anymore, and since most of the loopfiles() target functions are called
do_commandname() changed the name to that just so it's regular. None of
the changes are actually important. :)
|
|
|
|
(Still no -f support yet.)
|
|
for_each_pid_with_name_in_array_perform_callback_function_upon_translated_value() with name_to_pid(), comparing absolute paths or just basename() consistently as spotted by Lukasz Skalski, and adjust callers.
|
|
|
|
|
|
|
|
- one is because eglibc sets environ to NULL on clearenv(). I added check for environ being not NULL when iterating over environment variables
- switched xexec to xexec_optargs because command argument is a pointer to optarg which is freed by xexec.
|
|
|
|
Previous version didn't delete it, but exited without error. Neither was right.
|
|
|
|
|
|
readfile() semantics to be able to read into an existing buffer, or malloc its own if that's NULL.
|
|
|
|
|
|
|
|
|
|
|
|
|
|
option for optional arguments only suppliable with =.
|
|
- Rewrite most of the not lseek() logic
- Change meaning of len in line_list
- Use single instead of double linked list
|
|
|
|
|
|
|
|
|
|
- fix bugs introduced in the cleanups
- inline addrfds() and open_unix_socks() and simplify them
- use xpidfile()
- remove isNetwork from struct logfile
- invert the meaning of facility and level in struct logfile so
that they are automatically correctly initialized
- fix memory leak regarding the filenames of logfiles
- TT.sd was unused
|
|
- fix bugs in previous cleanups
- remove config from struct logfile
- simplify parse_config()
|
|
|
|
- simplify resolveconfig() -> now logger_lookup is also used in syslogd.c
- inline addrfds
- small cosmetical changes in parse_config_file()
|
|
- remove flag macros
- remove some unecessary gotos
- inline open_udp_socks() and getport()
- simplify resulting open_logfiles()
Now in the syslog.conf the port numbers for remote hosts are no
longer allowed to be hexadecimal. If there is need for hexadecimal
port numbers, one can as well accept octal ones and use base 0
in strtoul.
|
|
|
|
- Remove structure fd_pair so that sigfd can go into GLOBALS
- Remove struct typedefs
- Inline setup_signal()
- Small fix in Usage message
|
|
|
|
In syslogd.c get the definitions from <syslog.h>. For logger.c we
can't do this as well since it causes multiply defined symbols.
Instead we define a non-static lookup function in syslog.c for
logger.
|
|
|
|
fail with the ubuntu version, I _think_ these are upstream bugs? (Second opinions welcome...)
|
|
strings in sync. (todo: figure out how to make OLDTOY() automatically use macro. Still need the raw version for subset ala cp/mv though.)
|
|
|
|
|
|
|
|
|
|
* make help message more like others
* s/TT\.(.)Argu/TT.\1/g
* move environ to toys.h
* simplify failure messages
* clear password before quit
* not check what execve returns
* -lc
|
|
|
|
|
|
|
|
|
|
regex with embedded newline, multiple regex without -E.
|
|
|
|
sys_types had used char[_PATH_MAX] for 22-char max strings.
When this is done 48 times, it nearly doubles the size of toybox.
goto should only be used when it is the easiest way to bail out.
That does not mean "when we need to fall back to returning a one-liner
that asks user input", nor is it suitable for looping:
C has while () and do { } while (); for a reason.
valid was called once. As such, it belonged inline.
print_*menu could probably be inlined, but I did not do this yet
in case a table-driven approach works better.
This uses C string concatenation to break an overly long message up,
while not wasting function calls.
|
