From 869da8ce3752ce6f5aa63d302eebe60a2b5c8da8 Mon Sep 17 00:00:00 2001 From: Rob Landley Date: Sat, 7 May 2016 00:21:34 -0500 Subject: Work around increasingly insane compiler developers wanting to make everything undefined behavior so the optimizer can silently eliminate your entire program. --- main.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) (limited to 'main.c') diff --git a/main.c b/main.c index 9c70c961..14c4ff71 100644 --- a/main.c +++ b/main.c @@ -137,8 +137,10 @@ void toy_exec(char *argv[]) if (!(which = toy_find(*argv))) return; // Return if stack depth getting noticeable (proxy for leaked heap, etc). - if (toys.stacktop && labs((char *)toys.stacktop-(char *)&which)>6000) - return; + + // Compiler writers have decided subtracting char * is undefined behavior, + // so convert to integers. (LP64 says sizeof(long)==sizeof(pointer).) + if (toys.stacktop && labs((long)toys.stacktop-(long)&which)>6000) return; // Return if we need to re-exec to acquire root via suid bit. if (toys.which && (which->flags&TOYFLAG_ROOTONLY) && toys.wasroot) return; -- cgit v1.2.3