From 060a9f3380c5c778ab100f52fe5d1a41b0fd8a6c Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Fri, 7 Apr 2017 23:15:52 -0700 Subject: Speed up tail.test for shells without builtin printf. The test only needs echo, and Android currently doesn't use mksh's builtin printf; the toybox printf is fuller featured and less buggy, but a lot slower to call in a loop like this (and mksh doesn't fall back to the printf on the path if given something it can't handle, so we can't have the best of both worlds). Without this hack, the tail test takes as long as all the other tests put together. --- tests/tail.test | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) (limited to 'tests/tail.test') diff --git a/tests/tail.test b/tests/tail.test index 81dc871f..b148aebc 100755 --- a/tests/tail.test +++ b/tests/tail.test @@ -43,13 +43,12 @@ testing "noseek -c+ out of bonds" "tail -c +999" "" "" "$BIGTEST" makebigfile() { - for j in $(seq 1 100) do - printf "%s " $j + echo -n "$j " for i in $(seq 1 100) do - printf %s 123456789abcefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ + echo -n 123456789abcefghijklmnopqrstuvwxyzABCDEFGHIJKLMNOPQRSTUVWXYZ done echo done -- cgit v1.2.3