From 3b9cfa70db019fa9b43ddba2d5620bff6c72bad6 Mon Sep 17 00:00:00 2001
From: Denys Nykula <nykula@ukr.net>
Date: Sat, 22 Jun 2019 14:57:59 +0300
Subject: Fix mv with trailing slash in source.

Press tab, have bash complete dir name with a slash, notice musl
rename() dislikes that. Replace trailing slash in the cp loop with a
null character, if the command name is mv. Add the slash back if an
error occurs.
---
 tests/mv.test | 20 ++++++++++++++++++++
 1 file changed, 20 insertions(+)

(limited to 'tests')

diff --git a/tests/mv.test b/tests/mv.test
index f1f4a4f9..ed8922ac 100755
--- a/tests/mv.test
+++ b/tests/mv.test
@@ -96,6 +96,26 @@ testing "dir to existing dir" \
   "yes\n" "" ""
 rm -rf dir*
 
+# Trailing slash was once throwing: bad 'dir1/dir2/': Resource busy
+mkdir -p dir1/dir2
+testing "dir1/dir2 to ." \
+  "mv dir1/dir2 . && [ ! -e dir1/dir2 -a -d dir2 ] && echo yes" \
+  "yes\n" "" ""
+rm -rf dir*
+mkdir -p dir1/dir2
+testing "dir1/dir2/ to ." \
+  "mv dir1/dir2/ . && [ ! -e dir1/dir2 -a -d dir2 ] && echo yes" \
+  "yes\n" "" ""
+rm -rf dir*
+mkdir -p dir1/dir2
+testing "dir1/dir2/ to ./" \
+  "mv dir1/dir2/ ./ && [ ! -e dir1/dir2 -a -d dir2 ] && echo yes" \
+  "yes\n" "" ""
+rm -rf dir*
+testing "not/exists/ to ./" \
+  "mv not/exists/ ./ 2>&1 | grep -o not/exists/" \
+  "not/exists/\n" "" ""
+
 touch file1 file2
 chmod 400 file1 file2
 testing "force over unwritable" \
-- 
cgit v1.2.3