From 7d64dae54bde70744a9154b8ac1cbb09d03881c9 Mon Sep 17 00:00:00 2001 From: Rob Landley Date: Tue, 3 Sep 2013 18:43:32 -0500 Subject: Replace for_each_pid_with_name_in_array_perform_callback_function_upon_translated_value() with name_to_pid(), comparing absolute paths or just basename() consistently as spotted by Lukasz Skalski, and adjust callers. --- toys/lsb/killall.c | 15 +++++++-------- 1 file changed, 7 insertions(+), 8 deletions(-) (limited to 'toys/lsb/killall.c') diff --git a/toys/lsb/killall.c b/toys/lsb/killall.c index fe433282..59151d8b 100644 --- a/toys/lsb/killall.c +++ b/toys/lsb/killall.c @@ -32,21 +32,20 @@ static int kill_process(pid_t pid, char *name) { int ret; - if (pid == TT.cur_pid) return 1; + if (pid == TT.cur_pid) return 0; if (toys.optflags & FLAG_i) { sprintf(toybuf, "Signal %s(%d) ?", name, pid); - if (yesno(toybuf, 0) == 0) return 1; + if (yesno(toybuf, 0) == 0) return 0; } - toys.exitval = 0; - ret = kill(pid, TT.signum); - if (toys.optflags & FLAG_v) + if (ret == -1 && !(toys.optflags & FLAG_q)) + error_msg("bad %u", (unsigned)pid); + else if (toys.optflags & FLAG_v) printf("Killed %s(%d) with signal %d\n", name, pid, TT.signum); - if (ret == -1 && !(toys.optflags & FLAG_q)) perror("kill"); - return 1; + return 0; } void killall_main(void) @@ -76,7 +75,7 @@ void killall_main(void) TT.cur_pid = getpid(); - for_each_pid_with_name_in(names, kill_process); + names_to_pid(names, kill_process); if (toys.exitval && !(toys.optflags & FLAG_q)) error_exit("No such process"); } -- cgit v1.2.3