From 12f0744f340746b3a1c1accfdf993d6548f33e56 Mon Sep 17 00:00:00 2001 From: Elliott Hughes Date: Tue, 23 May 2017 17:35:49 -0700 Subject: Add and use xmmap. Everyone forgets that mmap returns MAP_FAILED rather than NULL on failure. Every use of mmap in toybox was either doing the wrong check, or no check at all (including the two I personally added). --- toys/posix/file.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) (limited to 'toys/posix/file.c') diff --git a/toys/posix/file.c b/toys/posix/file.c index 9fa8ed0d..658708cb 100644 --- a/toys/posix/file.c +++ b/toys/posix/file.c @@ -109,8 +109,7 @@ static void do_elf_file(int fd, struct stat *sb) return; } - map = mmap(0, sb->st_size, PROT_READ, MAP_SHARED, fd, 0); - if (!map) perror_exit("mmap"); + map = xmmap(0, sb->st_size, PROT_READ, MAP_SHARED, fd, 0); // We need to read the phdrs for dynamic vs static. // (Note: fields got reordered for 64 bit) -- cgit v1.2.3