From a89f8aa4f9181fa2de082ec3656743c64c85f6fc Mon Sep 17 00:00:00 2001 From: Rob Landley Date: Tue, 4 Feb 2014 06:16:44 -0600 Subject: More cleanup.html documentation, still way behind... --- www/cleanup.html | 77 ++++++++++++++++++++++++++++++-------------------------- 1 file changed, 42 insertions(+), 35 deletions(-) (limited to 'www/cleanup.html') diff --git a/www/cleanup.html b/www/cleanup.html index 4b4f894f..b0a9164c 100644 --- a/www/cleanup.html +++ b/www/cleanup.html @@ -72,11 +72,10 @@ not directly related to a specific cleanup series:

uuencode

-

This is an example of cleaning up something -that started in a condition most projects would be quite happy with. -The initial submission of uuencode and uudecode was a good high -quality contribution, written by a seasoned developer who did an excellent -job. It was still possible to shrink uuencode almost by half:

+

This is an example of cleaning up something most projects would be quite +happy with. The initial submission of uuencode and uudecode was high +quality code, written by a seasoned developer who did an excellent +job, but it was still possible to shrink the result almost by half:

Status: COMPLETE

uudecode

-

I tried to do the uudecode cleanup in smaller stages than uuencode:

+

The uudecode cleanup was my second "explain as I go along" cleanup, +and I tried to do it in smaller stages so it was easier to see what +changed from the diff:

@@ -126,13 +127,15 @@ description: todo (finish, move pending->posix, default y)

ifconfig

+

This series describes a thorough cleanup that took a while to do.

+

When ifconfig was submitted, it touched a half-dozen files. I glued it together into a single self-contained file, which needed a lot of cleanup. The final version is about 1/3 the size of the original.

This was the first command I started cleaning up with the intent of @@ -162,9 +165,12 @@ description: infrastructure cleanup from Isaac Dunham (which I mis-applied and then fixed plus some whitespace changes) -

  • commit: 862, -864, -866: todo
    • +
  • commit: 862, description: +remove unused headers and function, replace local buffer with toybuf, perror_exit(), avoid unnecessary assignment.
    • +
  • commit: 864, description: +blah
    • +
  • commit: 866, description: +blah
  • commit: 869 and 870, description: 869: @@ -181,8 +187,8 @@ after repeated inlining
  • commit: 883, description: move some common code to lib/ and posix headers to toys.h.
  • commit: 898, -description: Replace ifconfig_main() if/else staircase with a loop over -an array, genericize - prefix logic, inline a use of set_flags().
    • +description: Argument parsing. (Replace ifconfig_main() if/else staircase with a loop over +an array, genericize minus prefix logic, inline a use of set_flags().)
  • commit: 905, description: remove unnecessary wrapper function, inlining more functions, relying on the values of constants that don't change across architectures @@ -238,26 +244,27 @@ description: stat -
    -747 initial submission
-810 whitespace
-811
-871 whitespace (reindent from 4 spaces to 2)
-872 Felix Janda cleanup
-885 Felix Janda
-  move permission formatting (777 -> -rwxrwxrwx) from ls to lib so stat can reuse it.
-886 Felix Janda remove unimplemented options and clean up help text
-910 Felix Janda Add support for stating multiple files.
-911 Felix Janda Separate stat and statfs.
-912 commit description
-design pondering
-
- 914 916
-
    +

    A lot of the stat cleanup was done by Felix Janda.

    +

    Status: COMPLETE.

    -- cgit v1.2.3