From 25690854369a6bdf8e5f01da406fd350009ec135 Mon Sep 17 00:00:00 2001 From: Peter Hofmann Date: Sun, 29 Jan 2017 13:06:47 +0100 Subject: Remove GtkLevelBar, use bar included in GtkEntry I was still seeing this warning whenever the GtkLevelBar was set to a value of 0: Negative content width -2 (allocation 0, extents 1x1) while allocating gadget (node block, owner GtkLevelBar) This happens even in a minimal test program: #include int main(int argc, char **argv) { GtkWidget *win, *progress; gtk_init(&argc, &argv); win = gtk_window_new(GTK_WINDOW_TOPLEVEL); progress = gtk_level_bar_new(); gtk_level_bar_set_value(GTK_LEVEL_BAR(progress), 0); gtk_container_add(GTK_CONTAINER(win), progress); gtk_widget_show_all(win); gtk_main(); } It would appear that it's illegal to call gtk_level_bar_set_value() with a value of 0. Or, and that's just as likely, I don't understand how a GtkLevelBar is supposed to work. You don't even have to call gtk_level_bar_set_value() at all, since 0 is the default value of such a bar. All of this doesn't really matter, though, since GtkEntry has a built-in progress bar that we can use. CC #20. --- CHANGES | 4 ++++ 1 file changed, 4 insertions(+) (limited to 'CHANGES') diff --git a/CHANGES b/CHANGES index 175205c..7bb3ea5 100644 --- a/CHANGES +++ b/CHANGES @@ -13,6 +13,10 @@ next - Lariza now uses WebKit's multi-process model. This means that (most) tabs run as independent processes. If one tab crashes, it should not affect the others. + - The GtkLevelBar to show page loading progress has been removed. + Instead, we now use the progress bar which is already included in + GtkEntry (the input box). This is mostly a cosmetic change, but it + also eliminates some GTK warnings. [Added] - An external user-supplied program can be called for the current URI -- cgit v1.2.3