aboutsummaryrefslogtreecommitdiff
path: root/coreutils
diff options
context:
space:
mode:
authorDenys Vlasenko <vda.linux@googlemail.com>2017-08-06 21:23:03 +0200
committerDenys Vlasenko <vda.linux@googlemail.com>2017-08-06 21:23:03 +0200
commitb9be78070569e69960ba2b3c4098c3dc3316b9bd (patch)
treea74d7de183adcf7ef4b4584ff42c3443343271af /coreutils
parent184c738582eb190489dd2e9d120b1e036df65401 (diff)
downloadbusybox-b9be78070569e69960ba2b3c4098c3dc3316b9bd.tar.gz
sv,svc: fix NOEXEC fallout
function old new delta svc_main 145 162 +17 sv 1280 1297 +17 status 139 133 -6 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 2/1 up/down: 34/-6) Total: 28 bytes Signed-off-by: Denys Vlasenko <vda.linux@googlemail.com>
Diffstat (limited to 'coreutils')
-rw-r--r--coreutils/cksum.c1
-rw-r--r--coreutils/date.c1
-rw-r--r--coreutils/stty.c1
3 files changed, 3 insertions, 0 deletions
diff --git a/coreutils/cksum.c b/coreutils/cksum.c
index c0cf65d2a..059a33310 100644
--- a/coreutils/cksum.c
+++ b/coreutils/cksum.c
@@ -13,6 +13,7 @@
//config: cksum is used to calculate the CRC32 checksum of a file.
//applet:IF_CKSUM(APPLET_NOEXEC(cksum, cksum, BB_DIR_USR_BIN, BB_SUID_DROP, cksum))
+/* bb_common_bufsiz1 usage here is safe wrt NOEXEC: not expecting it to be zeroed. */
//kbuild:lib-$(CONFIG_CKSUM) += cksum.o
diff --git a/coreutils/date.c b/coreutils/date.c
index 89b281646..5a4ad5fe5 100644
--- a/coreutils/date.c
+++ b/coreutils/date.c
@@ -59,6 +59,7 @@
//config: MMDDhhmm[[YY]YY][.ss] format.
//applet:IF_DATE(APPLET_NOEXEC(date, date, BB_DIR_BIN, BB_SUID_DROP, date))
+/* bb_common_bufsiz1 usage here is safe wrt NOEXEC: not expecting it to be zeroed. */
//kbuild:lib-$(CONFIG_DATE) += date.o
diff --git a/coreutils/stty.c b/coreutils/stty.c
index 2292fa5ee..57e2cc30d 100644
--- a/coreutils/stty.c
+++ b/coreutils/stty.c
@@ -785,6 +785,7 @@ struct globals {
} FIX_ALIASING;
#define G (*(struct globals*)bb_common_bufsiz1)
#define INIT_G() do { \
+ setup_common_bufsiz(); \
G.device_name = bb_msg_standard_input; \
G.max_col = 80; \
G.current_col = 0; /* we are noexec, must clear */ \