aboutsummaryrefslogtreecommitdiff
path: root/libbb
diff options
context:
space:
mode:
authorDenis Vlasenko <vda.linux@googlemail.com>2008-05-15 21:30:45 +0000
committerDenis Vlasenko <vda.linux@googlemail.com>2008-05-15 21:30:45 +0000
commit6b06cb80be64fcf207bee734cc678c25434ed1a4 (patch)
treeaebc37ae3a2658fba3f57003102fa0dfb1a10ac8 /libbb
parent43d5d429fd7a80ca02eb8388f058fd9654cc118d (diff)
downloadbusybox-6b06cb80be64fcf207bee734cc678c25434ed1a4.tar.gz
more of -Wall fixes from Cristian Ionescu-Idbohrn.
Some are fixing real bugs. function old new delta syslogd_main 938 958 +20 get_signum 136 143 +7 obj_load 777 782 +5 recv_from_to 210 214 +4 get_next_block 1795 1799 +4 display_topmem_process_list 1117 1121 +4 logread_main 484 487 +3 buffer_fill_and_print 73 76 +3 kill_main 687 689 +2 ll_remember_index 240 241 +1 do_stats 452 453 +1 if_readconf 166 165 -1 display_process_list 1192 1191 -1 run_applet_and_exit 507 505 -2 print_signames 33 31 -2 parse_one_line 1092 1090 -2 find_out_spec 57 55 -2 add_ksymoops_symbols 421 419 -2 ash_main 1407 1402 -5 ------------------------------------------------------------------------------ (add/remove: 0/0 grow/shrink: 11/8 up/down: 54/-17) Total: 37 bytes
Diffstat (limited to 'libbb')
-rw-r--r--libbb/appletlib.c2
-rw-r--r--libbb/lineedit.c5
-rw-r--r--libbb/u_signal_names.c8
-rw-r--r--libbb/udp_io.c2
4 files changed, 9 insertions, 8 deletions
diff --git a/libbb/appletlib.c b/libbb/appletlib.c
index 9fe0cf963..3d5aef873 100644
--- a/libbb/appletlib.c
+++ b/libbb/appletlib.c
@@ -598,7 +598,7 @@ static void install_links(const char *busybox, int use_symbolic_links)
int (*lf)(const char *, const char *);
char *fpc;
- int i;
+ unsigned i;
int rc;
lf = link;
diff --git a/libbb/lineedit.c b/libbb/lineedit.c
index 62dcc55cd..9c802a35f 100644
--- a/libbb/lineedit.c
+++ b/libbb/lineedit.c
@@ -199,7 +199,7 @@ static void cmdedit_set_out_char(int next_char)
{
bb_putchar(c);
}
- if (++cmdedit_x >= cmdedit_termw) {
+ if (++cmdedit_x >= (int)cmdedit_termw) {
/* terminal is scrolled down */
cmdedit_y++;
cmdedit_x = 0;
@@ -861,7 +861,8 @@ static void input_tab(smallint *lastWasTab)
exe_n_cwd_tab_completion(matchBuf, find_type);
/* Sort, then remove any duplicates found */
if (matches) {
- int i, n = 0;
+ unsigned i;
+ int n = 0;
qsort_string_vector(matches, num_matches);
for (i = 0; i < num_matches - 1; ++i) {
if (matches[i] && matches[i+1]) { /* paranoia */
diff --git a/libbb/u_signal_names.c b/libbb/u_signal_names.c
index 7a0f75d6f..1dcbf5f2d 100644
--- a/libbb/u_signal_names.c
+++ b/libbb/u_signal_names.c
@@ -123,14 +123,14 @@ static const char signals[][7] = {
int get_signum(const char *name)
{
- int i;
+ unsigned i;
i = bb_strtou(name, NULL, 10);
if (!errno)
return i;
if (strncasecmp(name, "SIG", 3) == 0)
name += 3;
- for (i = 0; (size_t)i < ARRAY_SIZE(signals); i++)
+ for (i = 0; i < ARRAY_SIZE(signals); i++)
if (strcasecmp(name, signals[i]) == 0)
return i;
@@ -170,9 +170,9 @@ const char *get_signame(int number)
void print_signames(void)
{
- int signo;
+ unsigned signo;
- for (signo = 1; (size_t)signo < ARRAY_SIZE(signals); signo++) {
+ for (signo = 1; signo < ARRAY_SIZE(signals); signo++) {
const char *name = signals[signo];
if (name[0])
puts(name);
diff --git a/libbb/udp_io.c b/libbb/udp_io.c
index e968ecb66..689c39a82 100644
--- a/libbb/udp_io.c
+++ b/libbb/udp_io.c
@@ -113,7 +113,7 @@ recv_from_to(int fd, void *buf, size_t len, int flags,
} u;
struct cmsghdr *cmsgptr;
struct msghdr msg;
- socklen_t recv_length;
+ ssize_t recv_length;
iov[0].iov_base = buf;
iov[0].iov_len = len;